From: Florian Weimer <fweimer@redhat.com>
To: Szabolcs Nagy <szabolcs.nagy@arm.com>
Cc: jeremy.linton@arm.com, Jakub Jelinek <jakub@redhat.com>,
Jeff Law <law@redhat.com>, Carlos O'Donell <carlos@redhat.com>,
libc-alpha@sourceware.org
Subject: Re: [PATCH] aarch64: update NEWS about branch protection
Date: Wed, 29 Jul 2020 11:01:03 +0200 [thread overview]
Message-ID: <87lfj2r8z4.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <20200729084930.GS7127@arm.com> (Szabolcs Nagy's message of "Wed, 29 Jul 2020 09:49:31 +0100")
* Szabolcs Nagy:
> The 07/29/2020 10:11, Florian Weimer wrote:
>> * Szabolcs Nagy:
>>
>> > diff --git a/NEWS b/NEWS
>> > index 1ef4a0a7a4..0e6ad5edc4 100644
>> > --- a/NEWS
>> > +++ b/NEWS
>> > @@ -70,7 +70,9 @@ Major new features:
>> >
>> > * AArch64 now supports standard branch protection security hardening
>> > in glibc when it is built with a GCC that is configured with
>> > - --enable-standard-branch-protection. This includes branch target
>> > + --enable-standard-branch-protection (or if -mbranch-protection=standard
>> > + flag is passed when building both GCC target libraries and glibc,
>> > + in either case a custom GCC is needed). This includes branch target
>> > identification (BTI) and pointer authentication for return addresses
>> > (PAC-RET). They require armv8.5-a and armv8.3-a architecture
>> > extensions respectively for the protection to be effective,
>>
>> Please clarify if you need to pass the flags in CFLAGS or CC for glibc.
>> Thanks.
>
> cflags is enough, but it is hard to tell what
> the glibc build system does with the various
> cflags.
>
> if i simply override CFLAGS i get
> # error "glibc cannot be compiled without optimization"
Okay, I trust you that CFLAGS is enough.
Are there any ELF notes I should watch out for?
My RM delegation has already expired, so I cannot approve your patch.
Thanks,
Florian
next prev parent reply other threads:[~2020-07-29 9:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 8:08 Szabolcs Nagy
2020-07-29 8:11 ` Florian Weimer
2020-07-29 8:49 ` Szabolcs Nagy
2020-07-29 9:01 ` Florian Weimer [this message]
2020-07-29 9:17 ` Szabolcs Nagy
2020-07-29 10:04 ` Florian Weimer
2020-07-29 10:25 ` Szabolcs Nagy
2020-07-29 12:51 ` Florian Weimer
2020-07-31 6:58 ` Szabolcs Nagy
2020-07-31 13:22 ` Szabolcs Nagy
2020-08-03 18:53 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfj2r8z4.fsf@oldenburg2.str.redhat.com \
--to=fweimer@redhat.com \
--cc=carlos@redhat.com \
--cc=jakub@redhat.com \
--cc=jeremy.linton@arm.com \
--cc=law@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).