From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by sourceware.org (Postfix) with ESMTPS id C75973858407 for ; Fri, 9 Feb 2024 13:16:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C75973858407 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nefkom.net ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C75973858407 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=212.18.0.9 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707484580; cv=none; b=vuSlHzM2HRsRM9WnxZhw3VRErhWLNAn8xxCD4iJuTwVX5rcm4/eEPsNoautaLxRs4+lHS7Q+H6yITVvxMYUMkdeIJp1i1ZuLG8P9n9hBIfMeDY5jTDWPpfobriZdkY+O3/4sfIWylrgkMnSDmXPYKuIEl78IgGyf5xH1MSawbvQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707484580; c=relaxed/simple; bh=ek4CPhAqh5Ywgyh1BCgpOZj9vCzvyAPbS8VO0fEr0FQ=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=a42k08/Zf+0UfVWaEGGJzk7WbD3ywH4/u/1M4eMkci+eYMcRVkC+QHCvXJ+iwEhhhEXx/HhgTrRnK6T3VWIZdMHdp3Cc5DeupXqrnUY844UWjM99tMtcCcsxlp8DCn616s26JpoWjT7gzdYoXQygkDURSJV3A6KSsrUv9eZ402s= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4TWZ9s1BtYz1qsP4; Fri, 9 Feb 2024 14:16:17 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 4TWZ9s0qgsz1qqlW; Fri, 9 Feb 2024 14:16:17 +0100 (CET) X-Virus-Scanned: amavis at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavis, port 10024) with ESMTP id vWLrp8vL2vOr; Fri, 9 Feb 2024 14:16:16 +0100 (CET) X-Auth-Info: cLtFPc3kiovSga7YN6b9dJLgzM/Spqiazoo+6cdnOBsIILYYQWXAVUO8zp1+lg1V Received: from igel.home (aftr-62-216-202-49.dynamic.mnet-online.de [62.216.202.49]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 9 Feb 2024 14:16:16 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id CC51D2C1A98; Fri, 9 Feb 2024 14:16:15 +0100 (CET) From: Andreas Schwab To: "H.J. Lu" Cc: libc-alpha@sourceware.org, fweimer@redhat.com Subject: Re: [PATCH] elf: Properly remove the initial 'env' command In-Reply-To: <20240209125449.2352780-1-hjl.tools@gmail.com> (H. J. Lu's message of "Fri, 9 Feb 2024 04:54:49 -0800") References: <20240209125449.2352780-1-hjl.tools@gmail.com> X-Yow: I have a TINY BOWL in my HEAD Date: Fri, 09 Feb 2024 14:16:15 +0100 Message-ID: <87mss9aicg.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Feb 09 2024, H.J. Lu wrote: > diff --git a/elf/tst-rtld-list-diagnostics.py b/elf/tst-rtld-list-diagnostics.py > index 9e70e74bf8..dfba94de64 100644 > --- a/elf/tst-rtld-list-diagnostics.py > +++ b/elf/tst-rtld-list-diagnostics.py > @@ -294,7 +294,11 @@ def main(argv): > check_consistency_with_manual(opts.manual) > > # Remove the initial 'env' command. > - parse_diagnostics(opts.command.split()[1:]) > + options = [] > + for o in opts.command.split()[0:]: > + if o != 'env': > + options.append(o) Why does it need to do that in the first place? -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."