From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by sourceware.org (Postfix) with ESMTPS id 1578B3858D1E for ; Sun, 19 Mar 2023 14:16:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1578B3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nefkom.net Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4Pfg0C6rz8z1r1Mh; Sun, 19 Mar 2023 15:16:27 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4Pfg0C6RZ6z1qqlS; Sun, 19 Mar 2023 15:16:27 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 30CIxjwryFko; Sun, 19 Mar 2023 15:16:27 +0100 (CET) X-Auth-Info: 1R0wT3ZqLULOMkNwFJGHMRT3MEftbCiC4vSqnYEp6VSPrjh9PsLtXIo6iDJx7Ap5 Received: from igel.home (aftr-82-135-86-168.dynamic.mnet-online.de [82.135.86.168]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Sun, 19 Mar 2023 15:16:27 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id 09CD92C1550; Sun, 19 Mar 2023 15:16:27 +0100 (CET) From: Andreas Schwab To: Julian Squires Cc: Julian Squires via Libc-alpha Subject: Re: [PATCH] posix: Fix some null deferences in wordexp [BZ #18096] References: <20230318125950.3611824-1-julian@cipht.net> <871qlmyu2f.fsf@igel.home> <87h6ugx34o.fsf@cipht.net> X-Yow: Impudent.. Yet possessing a certain ALUMINUM SILICATE overbite....Needs REDDY-WHIP!! Date: Sun, 19 Mar 2023 15:16:26 +0100 In-Reply-To: <87h6ugx34o.fsf@cipht.net> (Julian Squires's message of "Sun, 19 Mar 2023 11:19:27 -0230") Message-ID: <87mt48j079.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mär 19 2023, Julian Squires wrote: > The assertion failure mentioned, where seen_hash is set, triggering the > assertion below, where free_value is set but value is NULL: > > if (seen_hash) > { > [...] > if (free_value) > { > assert (value != NULL); > free (value); > } That assertion should be removed, it serves no purpose. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."