From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id CFDDD3858C50 for ; Fri, 17 Mar 2023 22:01:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CFDDD3858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679090490; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4z05TXFeeu90Ft7/CbOgmtm1tzezjhdsDddZmmDjuu0=; b=hOjfEGbivYo/2M4wKFOxcL0LI2rcJsyJojKAycDD813MCrv64YthsWVWNqq6/8y3uA0Oji mUNQlpo0toFCcvfnzT5Jk5p/WGoOBOXLO+DUgZuXzGdaWiBeKU3/fkFdnLCW3uuhrbvEvq slEEbMZ19B1b7kf4BcKJpMBnOGVklyw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-144-Xc-fRGC2MVG1kXYRxsyylA-1; Fri, 17 Mar 2023 18:01:29 -0400 X-MC-Unique: Xc-fRGC2MVG1kXYRxsyylA-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DC24280C8C1 for ; Fri, 17 Mar 2023 22:01:28 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.193.60]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 43BEF492B00; Fri, 17 Mar 2023 22:01:28 +0000 (UTC) From: Florian Weimer To: DJ Delorie via Libc-alpha Cc: DJ Delorie Subject: Re: [patch v2] aligned_alloc: conform to C17 References: Date: Fri, 17 Mar 2023 23:01:26 +0100 In-Reply-To: (DJ Delorie via Libc-alpha's message of "Fri, 17 Mar 2023 15:02:36 -0400") Message-ID: <87mt4bt4uh.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * DJ Delorie via Libc-alpha: > diff --git a/malloc/Versions b/malloc/Versions > index c763395c6d..28f41a94f3 100644 > --- a/malloc/Versions > +++ b/malloc/Versions > @@ -67,6 +67,9 @@ libc { > GLIBC_2.33 { > mallinfo2; > } > + GLIBC_2.38 { > + __libc_aligned_alloc; > + } > GLIBC_PRIVATE { > # Internal startup hook for libpthread. > __libc_malloc_pthread_startup; Why do we need to export the __libc_aligned_alloc symbol? That doesn't seem to be right. We should simply change the behavior of the existing aligned_alloc symbol. If you do not want to change behavior for existing binaries (why?), you should still export a new aligned_alloc@@GLIBC_2.38 symbol (no __libc_ prefix). (Manpage Cc: dropped.) Thanks, Florian