From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id EEC453858D1E for ; Mon, 13 Mar 2023 17:10:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EEC453858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32DH0C1Z022841; Mon, 13 Mar 2023 17:10:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=references : from : to : cc : subject : in-reply-to : date : message-id : content-type : mime-version; s=corp-2022-7-12; bh=e/Mm9OV0rACLzChT1iUUUqEpDQoUF42YV+5Jw6J6az4=; b=zQEl9dlaVRG1wLZXYT/UxO2DMo7y4yyNYsLmeYp35jN1HT0nCY8qIcZNF8mmwBZzMN0A wqYUQ2uUca5LLBPDH7R4SMsX4GWdLu4iaopS2MgJdcspHOzwpWYyB8hEzM/S0izwXjIO ORe8/DTF/FzNq001iKnW76LszmCamy3kzNp4XzFD9q2D+/YK1b8gxWVX8JPrM38wLcsp zXaAGfV/M9eDWtY6XW07CFzhjPGch6aE0lHyWz3p+BOOfmCYXdy2OO37PXOGDxw+gkza xrG6Brjrv4bsLSNNda7vs42BRocfYgnPR4wgn3ymbm3GWleO7GZsofrOTvPx9kXNe/jc Ag== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3p8ge2vcb1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Mar 2023 17:10:19 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 32DG86Dj007514; Mon, 13 Mar 2023 17:10:19 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2101.outbound.protection.outlook.com [104.47.58.101]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3p8g3br27x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Mar 2023 17:10:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZjyMYlSMfsL7tAHCOOQOeRdCzHZcem6bwyrIwA9PftIn6FmkDMdxf2B9vbqEIdjr3fGwtBG0i4KwqKuZ3TzClj8xlgtprqQRwN7vmCE8svmIP0AADwgAMypbZybOT1n6CN+NtydX4d4sSU+d/C975e3cCE6UkyDnuEYyOXLY40OFUZJnlxLijAmLYqlrfNod3hBHm5XzrDuhw6ENMN1YcyJMbdAXI/Rnn+xBZFsacrafQ2NQtgy01Cpy2ZxnmZ7BxcDQEhyqBEGJU5V/m942oKaZn7BeYRXmzzB5hcgzvJbKRiEe30UN6JeIOE4FUImIFFyTHpEJtZxmy2iM8s0p6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e/Mm9OV0rACLzChT1iUUUqEpDQoUF42YV+5Jw6J6az4=; b=h6exg2dTf89Vsx1a9nlzKO0ucw3Titt+09S2egxCo2Qgw7bgm3rrcVvPHcO7Co1utZz307wInUOasGQMcvNKyDEWGKM6dYXEKN4pu/mG33dhyksB7BjiXYgMm01kafKJrXAnaxcGA9T1IPGEzYLG4+wFKLWWmn0BtNTdM5HgAaUi9oi9iwYsiDA6AVvcrUhsQBUBuIJ5ljUZqtcwknCxea+9QouydPI0YqrEGVWBEbYeUKv0IC1j55XBRWdUgG24qXu7gE959EdJ7o83OyU64FultHOVHkUyQTL1OjZdCJivWoEpOijQRRz6mMCiKglrZDjVwLwCJJWH95TIxt/0ww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e/Mm9OV0rACLzChT1iUUUqEpDQoUF42YV+5Jw6J6az4=; b=CbzxT0YAF0eL11lvx5iq3o0vZ1RKQXBZRZfSlMaWMArOmTf3RUjnxq9xyfn+lZWNxStLYp3GXzNSaPJtCSh54Ia9iLIaqx81rptLJ/gDI3GTkVFRKfr6EbQDHkJVdulWuUqs0MB7ZWnVs/KKDbw/I3U6eedlkrYX4htdO0SwNpo= Received: from BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) by SJ0PR10MB6398.namprd10.prod.outlook.com (2603:10b6:a03:44a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.24; Mon, 13 Mar 2023 17:10:15 +0000 Received: from BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::a502:c948:c3f6:9728]) by BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::a502:c948:c3f6:9728%6]) with mapi id 15.20.6178.022; Mon, 13 Mar 2023 17:10:15 +0000 References: <20230310143558.361825-1-cupertino.miranda@oracle.com> <20230310143558.361825-2-cupertino.miranda@oracle.com> <87edptulvd.fsf@oldenburg.str.redhat.com> <87y1o10xs7.fsf@oracle.com> User-agent: mu4e 1.4.15; emacs 28.1 From: Cupertino Miranda To: Cupertino Miranda Cc: Florian Weimer , jose.marchesi@oracle.com, elena.zannoni@oracle.com, adhemerval.zanella@linaro.org, libc-alpha@sourceware.org Subject: Re: [PATCH] Created tunable to force small pages on stack allocation. In-reply-to: <87y1o10xs7.fsf@oracle.com> Date: Mon, 13 Mar 2023 17:10:09 +0000 Message-ID: <87mt4g1ssu.fsf@oracle.com> Content-Type: text/plain X-ClientProxiedBy: LO4P123CA0321.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:197::20) To BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN6PR1001MB2340:EE_|SJ0PR10MB6398:EE_ X-MS-Office365-Filtering-Correlation-Id: d9b315bc-66ae-4c45-4a25-08db23e5d040 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tv6sAtYwKiC+pT4F0aJraWnaB9EoObh1vtp22EPrJOYyiXh4OD5anpEr0XiXe3gLzTS9L/atvDUru1WEX7cpcxD+MsFrFOcLYWysCeEuDGcbF70U+43svRh+oFFjHIQ5H3m532+ZlS7AdooRnucfZ8+FEHbU6JXUocZ9m3eTCReSUJ6dGOy0IoWt+M3v2zZ6dmBjyG9nh/CxNLXX5Ni0eZ4vxs7+wA56UaOi7dN1f4ZtAz2FQ6FNisP+4qCq7/JorFPNB3tcxFrWOsRooUlzg9Fr0NE0GeJYNjH8Sz6UNQOnBnYdpzjsGAC9cBPIItycjgtsA8XbgnHNVKHjVQzknFWWFDFLMMtKgSTWwEpJZbVWEIjCRmtEFOMJIvGpJtqmPd1c0U/Alddrlyz5RYymgIaWg4bzhrNcSY4+hrpZsgo+mgFPYpeLywctPm0E1xEr1VCX4SUNaetSXn3jZoCTw3KhgUgrIzkhwpuaQAieA6Zw6j55stZpGVGh4HtPGwTmW+pT4Gr6d75xwsJR5+o5NiXzSbv4avDlJG5pKWTVHv41ensOKqec03iPsNDEm/FJOzLUvl/s0vFDq3CxTWKysdlumk7eI0kL/thLAt8ayJ8TRut0YlsuIgAgMnITLpaNmwt9m6W/jr5YU9FPk+Mnkw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR1001MB2340.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(136003)(396003)(376002)(346002)(366004)(451199018)(4326008)(8676002)(41300700001)(66946007)(66556008)(66476007)(6862004)(5660300002)(44832011)(6486002)(186003)(8936002)(6512007)(6506007)(37006003)(6666004)(316002)(2616005)(478600001)(36756003)(86362001)(6200100001)(38100700002)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Zozv0+5Kx2SD9h7sY+h38NVso6dmvv3ge4yd1uXZJ5eFVDoiC88P/lxCIwcv?= =?us-ascii?Q?jNxnsUmhbIQPSCisjScdIZaKM7Qk2UOh6lrlFcqG88un+tjBgUNpGlhx2bit?= =?us-ascii?Q?K2ozJOP/rHnsoJWW11gbx8JZfJAUrDe4ESsClva3zOV9vfuE9JcA8c6D75IJ?= =?us-ascii?Q?wnnf0rAsud6CA+SeP6LS5qurmMGkMXQGQaibvakl0xjspnuVxm4pNYCgdU5c?= =?us-ascii?Q?uP9Jt0r3/r6UvNgDtXB/S6NPNrKeL5PqqW2BYbbuRth0A9FhbKy/PMXLSg/A?= =?us-ascii?Q?8mDeqgn2IiKS5mPZFMoLnTzJZEwVOuvs7Y13x9ZnFGnlBM4cn1sjlGRyOxAO?= =?us-ascii?Q?Kk5urTzvZw4thAlQc6cKgdlBqHj9xznadznbptBiqE9/CoKNdbDQ+yYTm9Yw?= =?us-ascii?Q?3Do44hJ+OoHLjzgW/fWrOdjg2zgmQRnYq2r+aEtIbqi471L+a8WOiCbPmP9B?= =?us-ascii?Q?BgDhgvtvwnFKPrpMrjzmz+lptnw5kx6Xq/FgxQ1EzzVJXiwFS2niy7uE4EKF?= =?us-ascii?Q?LQcgudl/o3HInuou0wneC1yPPf4SMIDMteR/TlPwcWAFYwy7amAxwJ9NLHi8?= =?us-ascii?Q?6Gf+xqv0e0AR908kXQTHBKBhAjj3uQKgWjXR/GdJyjShsJ/ox39HPEMNIPKk?= =?us-ascii?Q?EPUVLDXwR5xTIJFRGvD45j3nbEEtknn/MRQkYPMPvvP+M7+gN0o1WnyX/Yoa?= =?us-ascii?Q?6sUw99VhvAG3KTUYcXqY1pI/EyUPgrzC02LlYqjPj9HLtxxMIZp5jLk6uuOM?= =?us-ascii?Q?2baex1UHNeF8S09bsLclPowwVzJ5xWw/v+JYrSJyxdVmOcpx+wxN7anY015g?= =?us-ascii?Q?UaEmNL4rUSYHiC3hvNIbY+kGUwHsqhIjRO7l+nCw7gieAccYuhj9fTge1NdB?= =?us-ascii?Q?Qm06r6uf9SO8C8uTiTJ54ThJR8BtY30oLraqpDIWQEjUVvoRJWKxRZsyPAfg?= =?us-ascii?Q?k76qbD6ohEkAMyLnyhVMJiPJ9gZoavaYmBpEhs6Wj3XEcae1Ei6XoW6+uY1Z?= =?us-ascii?Q?SLHo35mWIDm+9NZaCN4cGMHZ+9/1dxJ0W+c+CIbK+pTkdzWPmR6Asg8wbgZU?= =?us-ascii?Q?Qj5oaqZUXjmFvy6uWW9urP+qtOQ3bHzqQK4O5LN+W4pPLrwiosC/X9BOA6YD?= =?us-ascii?Q?jfuxyprZe3RV4ciqgOus0svXaN9zJAVhzISoXNXx9tcEfR+blFbSBkSujtEG?= =?us-ascii?Q?HgTTE5LtjuvTbfa696dYlukAHmJobNXpZ41cS5zZ1JrHeJKk9cvL53MOcQes?= =?us-ascii?Q?nXRc6n2sh985GH2l5dIHEfctwewpD0p1BC2LztfY9AK1iEz87QpBCbo5GAeN?= =?us-ascii?Q?hIxR84GCFgJMe5Njrv7WZB+4osjrCk7n3qDOKEGkApj/J0OuS8LWe5M9GO3R?= =?us-ascii?Q?HpDBv+D+OYxy3ixTu5uQQ+u5ecoTDcrND4v34rlE0t+GcTzLrZ7z1LT5OSe9?= =?us-ascii?Q?iSUKtbsQbSsedOw0EG/z7h6OpF0ERw3Sosi//Pb87d0oIoTb3Y6d0iPHMOfS?= =?us-ascii?Q?57XAiLCk1twO0/IQdLl8lG7CIBUhy7wx6nW+FCxWOhfNiE8mnPaz7Z+7NX0O?= =?us-ascii?Q?yHlYp7w+D4cD1yDy3F7flZeLuvTs0MwCbzPwEkvDGb7iD20cu+H/zGVBlYIQ?= =?us-ascii?Q?Hq5r2oI1n1bqJQVeDS4JV5ph5Fe4RomY3N9Z7Yd6Xjos?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Slv7sa9Vde1OFaLc9O2p+cQVzl5eRhx3D4L6D3rxF44cManoCWIr08RBl5/Mrs3syLAe+zp1ZTly/Q1pt9rstx1BX7cr1WaaB2dO13G9/isNd+3Ya4jzOE/FQjpgvBvv9cVG0eRjvrU6SKihD7oL6xma4kdTLn9cW2tc/a755dTXd0WMvB5kwZg+s2dJ4z8uxSTjMh8mmExX8unz6Bts7v7BGsZmRrsxw4c/pJtzsvn+JpfFVdTLTB9f/2hARlQUKOg9dTCUE+fQR3FpvTk5GQUtVLrosq6Rn0HGQieuQwqdd+NhXayo242ZFpJgkShwmx7peTMgOJ4B95Hx/XyMuZ49U0GulPxIMpVDyjMTWQiqSSOlepHLKZy7aRnpG8VbNh0ZW2KlReS3Xgd0rc/lOn0JIV7evakzUjMux2oGgPTSkfboMMINIYAnvYfxSH3IumIkSc6hi5mbwWqoYBRQym9Uq1rn4vV2cfcMhMvBk8Rp5Q2sDrwi2n35KQQSbx9dzVUIv9HDgC3hi7Ubc4S+BjveX92OOkceYXLgUgpprnG1iLrhGn5o6206qiFyj8H4RjWbx6e05DVT79u1kkqzI07DjJE6qnQMnok8oTBUPcE2Z0CHYJseKcAwBiG4MYNAPkI7Ets+1+F9MplOnkDNqqmOCCmBmS5RVU9qud8KxJ54PvOlhA6Ru/CJaJz2y0lJe7+7m3u+khYWl5zePwFYOathCbnRpdmKYTL4oA05+leFh5eTL7mKSnV4MwnNqRqiAgOGjpi07zsPD/8aOOKNJJ4qu0nWdg4ZWvogZSN9G+yGiHfD7lObEeDyvY7QN3Qo X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: d9b315bc-66ae-4c45-4a25-08db23e5d040 X-MS-Exchange-CrossTenant-AuthSource: BN6PR1001MB2340.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2023 17:10:15.3757 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qjI1p0YidJZDUkYXMgjkLvopaLuRQwOorXMZvdWkxwhFqWO7JCn578rQcVHvMYqHr53u+BHBIiVDlctb0dc78HqEZHOhQ7BFFQ+IwoNJsbg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB6398 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-13_08,2023-03-13_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 bulkscore=0 adultscore=0 mlxlogscore=999 malwarescore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2303130134 X-Proofpoint-GUID: NaOGcNPSCYZj71YFIJbJIqcO0OEsdzzV X-Proofpoint-ORIG-GUID: NaOGcNPSCYZj71YFIJbJIqcO0OEsdzzV X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Cupertino Miranda via Libc-alpha writes: > Hi Florian > >> * Cupertino Miranda via Libc-alpha: >> >>> +static void >>> +TUNABLE_CALLBACK (set_stack_hugetlb) (tunable_val_t *valp) >>> +{ >>> + enum malloc_thp_mode_t thp_mode = __malloc_thp_mode (); >>> + /* >>> + Only allow to change the default of this tunable if the system >>> + does support and has either 'madvise' or 'always' mode. Otherwise >>> + the madvise() call is wasteful. >>> + */ >>> + switch(thp_mode) >>> + { >>> + case malloc_thp_mode_always: >>> + case malloc_thp_mode_madvise: >>> + __nptl_stack_hugetlb = (int32_t) valp->numval; >>> + break; >>> + default: >>> + break; >>> + } >>> +} >> >> I suspect that quite a few failing madvise calls are cheaper than the >> those three system calls in __malloc_thp_mode. In addition, >> __malloc_thp_mode may fail due to future kernel changes, disabling the >> tunable by accident. > Thanks for your review. Ok, I did not check the inner workings of > malloc_thp_mode. I used it by suggestion from the RFC thread. > I will prepare a version removing it. > >> >> Thanks, >> Florian kkjjj b