From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 24265394E887 for ; Thu, 8 Dec 2022 18:13:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 24265394E887 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670523214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eenmAK+YMtFvO6c1o+f7D8Hd+vwNi0o9QxfdSTbml24=; b=AljLniqFe49anQcZFiKfIm/C5iCexQQ5wfqx+GUFwkJgrTg6/YakEZVGH55+K/11Mi++HL go9EuVtXHRarrcM86kIspkP2u0anVeKcbLe7yXLWqEwu4nuqtjOESmhz8qTpIea49RYXJA IBxruUvHooYchlGoAmWkPkeW4UhoAxk= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-145-DjX70whyPZOq8x5-8JosRQ-1; Thu, 08 Dec 2022 13:13:31 -0500 X-MC-Unique: DjX70whyPZOq8x5-8JosRQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2CB24380407B; Thu, 8 Dec 2022 18:13:31 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AE148C1908A; Thu, 8 Dec 2022 18:13:30 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Netto Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v2] : Make strptime available by default References: <87cz97rv5u.fsf@oldenburg.str.redhat.com> <2af38d17-f641-d36a-b090-a3e00f8cd14e@linaro.org> Date: Thu, 08 Dec 2022 19:13:27 +0100 In-Reply-To: <2af38d17-f641-d36a-b090-a3e00f8cd14e@linaro.org> (Adhemerval Zanella Netto's message of "Thu, 8 Dec 2022 14:13:01 -0300") Message-ID: <87mt7xhigo.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Adhemerval Zanella Netto: > On 28/11/22 11:49, Florian Weimer via Libc-alpha wrote: >> This matches what FreeBSD does. >> > > > LGTM, thanks. > > Reviewed-by: Adhemerval Zanella > >> --- >> v2: Remove unneccesary parentheses. >> time/time.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/time/time.h b/time/time.h >> index d18089116e..0919e578d4 100644 >> --- a/time/time.h >> +++ b/time/time.h >> @@ -101,7 +101,7 @@ extern size_t strftime (char *__restrict __s, size_t __maxsize, >> const char *__restrict __format, >> const struct tm *__restrict __tp) __THROW; >> >> -#ifdef __USE_XOPEN >> +#if defined __USE_XOPEN || defined __USE_MISC >> /* Parse S according to FORMAT and store binary time information in TP. >> The return value is a pointer to the first unparsed character in S. */ >> extern char *strptime (const char *__restrict __s, >> >> base-commit: f704192911c6c7b65a54beab3ab369fca7609a5d >> I think this change has been vetoed by Andreas. I assume he wants us to define __USE_XOPEN by default to check all visiblities at once. Florian