From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id CCE04385AC24 for ; Tue, 6 Sep 2022 12:11:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CCE04385AC24 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662466315; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=naqClqSsu/6mrZgt+wU2N0vJjWjP6lLVy31iJ2zxCjA=; b=TiBhXtk0aZqWpVZqDJ1mV/nlTURMA2yaurmv8+jBDlD84qhGYbRAPR0lSlyk7L01rqvVBj oKX11R2xoLsqPnphpWSVVldFSqHOhgiIaLwtI3A0uleQu9Sx7p6zPgpuX3+T9e+/B6s/db UXkJG5hHcdfE6FBKpC53gMmKGQfRCCc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-121-S1IMk_yQMhaIu-0gDXNkxA-1; Tue, 06 Sep 2022 08:11:54 -0400 X-MC-Unique: S1IMk_yQMhaIu-0gDXNkxA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1071485A585; Tue, 6 Sep 2022 12:11:54 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.109]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 58A2D492C3B; Tue, 6 Sep 2022 12:11:53 +0000 (UTC) From: Florian Weimer To: Wilco Dijkstra via Libc-alpha Cc: Wilco Dijkstra Subject: Re: [PATCH] Use C11 atomics instead of atomic_bit_set/bit_test_set References: Date: Tue, 06 Sep 2022 14:11:51 +0200 In-Reply-To: (Wilco Dijkstra via Libc-alpha's message of "Mon, 5 Sep 2022 16:35:40 +0000") Message-ID: <87mtbc66t4.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Wilco Dijkstra via Libc-alpha: > Replace the 3 uses of atomic_bit_set and atomic_bit_test_set with atomic_fetch_or_acquire. Long line. Why is acquire MO required here? I don't see any synchronizing store. Isn't this mostly a compiler barrier for use-after-free detection? Thanks, Florian