From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v8 3/9] benchtests: Add arc4random benchtest
Date: Tue, 12 Jul 2022 11:29:19 +0200 [thread overview]
Message-ID: <87mtdeu1ao.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20220629213428.3065430-4-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Wed, 29 Jun 2022 18:34:22 -0300")
* Adhemerval Zanella:
> diff --git a/benchtests/bench-util.h b/benchtests/bench-util.h
> index d0e29423aa..52eded5590 100644
> --- a/benchtests/bench-util.h
> +++ b/benchtests/bench-util.h
> @@ -16,6 +16,12 @@
> License along with the GNU C Library; if not, see
> <https://www.gnu.org/licenses/>. */
>
> +/* Prevent compiler to optimize away call. */
> +#define DO_NOT_OPTIMIZE_OUT(__value) \
> + ({ \
> + __typeof (__value) __v = (__value); \
> + asm volatile ("" : : "r,m" (__v) : "memory");\
> + })
__ is not needed for macro arguments. I think the macro would be more
useful if it returned __v. Could you put this into a separate patch?
Thanks.
Florian
next prev parent reply other threads:[~2022-07-12 9:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 21:34 [PATCH v8 0/9] Add arc4random support Adhemerval Zanella
2022-06-29 21:34 ` [PATCH v8 1/9] stdlib: Add arc4random, arc4random_buf, and arc4random_uniform (BZ #4417) Adhemerval Zanella
2022-07-12 8:57 ` Florian Weimer
2022-07-12 16:57 ` Adhemerval Zanella Netto
2022-07-12 17:15 ` Florian Weimer
2022-07-12 17:21 ` Adhemerval Zanella Netto
2022-06-29 21:34 ` [PATCH v8 2/9] stdlib: Add arc4random tests Adhemerval Zanella
2022-07-12 9:20 ` Florian Weimer
2022-07-12 17:17 ` Adhemerval Zanella Netto
2022-06-29 21:34 ` [PATCH v8 3/9] benchtests: Add arc4random benchtest Adhemerval Zanella
2022-07-12 9:29 ` Florian Weimer [this message]
2022-07-12 17:26 ` Adhemerval Zanella Netto
2022-06-29 21:34 ` [PATCH v8 4/9] aarch64: Add optimized chacha20 Adhemerval Zanella
2022-07-12 9:30 ` Florian Weimer
2022-06-29 21:34 ` [PATCH v8 5/9] x86: Add SSE2 " Adhemerval Zanella
2022-06-29 21:34 ` [PATCH v8 6/9] x86: Add AVX2 " Adhemerval Zanella
2022-06-29 21:34 ` [PATCH v8 7/9] powerpc64: Add " Adhemerval Zanella
2022-06-29 21:34 ` [PATCH v8 8/9] s390x: " Adhemerval Zanella
2022-06-29 21:34 ` [PATCH v8 9/9] manual: Add documentation for arc4random functions Adhemerval Zanella
2022-06-29 21:45 ` Noah Goldstein
2022-06-29 21:53 ` Adhemerval Zanella
2022-06-29 22:05 ` Noah Goldstein
2022-06-30 7:58 ` Yann Droneaud
2022-06-30 19:37 ` Adhemerval Zanella
2022-06-29 21:55 ` Adhemerval Zanella
2022-07-12 9:31 ` [PATCH v8 0/9] Add arc4random support Florian Weimer
2022-07-12 17:36 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtdeu1ao.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).