From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4CFB43858C50 for ; Tue, 12 Jul 2022 09:29:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4CFB43858C50 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-428-J5Y6adR2NIeyT9608_TMng-1; Tue, 12 Jul 2022 05:29:22 -0400 X-MC-Unique: J5Y6adR2NIeyT9608_TMng-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8D6328032F0; Tue, 12 Jul 2022 09:29:22 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.160]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C8DED40B40C8; Tue, 12 Jul 2022 09:29:21 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v8 3/9] benchtests: Add arc4random benchtest References: <20220629213428.3065430-1-adhemerval.zanella@linaro.org> <20220629213428.3065430-4-adhemerval.zanella@linaro.org> Date: Tue, 12 Jul 2022 11:29:19 +0200 In-Reply-To: <20220629213428.3065430-4-adhemerval.zanella@linaro.org> (Adhemerval Zanella's message of "Wed, 29 Jun 2022 18:34:22 -0300") Message-ID: <87mtdeu1ao.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2022 09:29:41 -0000 * Adhemerval Zanella: > diff --git a/benchtests/bench-util.h b/benchtests/bench-util.h > index d0e29423aa..52eded5590 100644 > --- a/benchtests/bench-util.h > +++ b/benchtests/bench-util.h > @@ -16,6 +16,12 @@ > License along with the GNU C Library; if not, see > . */ > > +/* Prevent compiler to optimize away call. */ > +#define DO_NOT_OPTIMIZE_OUT(__value) \ > + ({ \ > + __typeof (__value) __v = (__value); \ > + asm volatile ("" : : "r,m" (__v) : "memory");\ > + }) __ is not needed for macro arguments. I think the macro would be more useful if it returned __v. Could you put this into a separate patch? Thanks. Florian