From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fweimer@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by sourceware.org (Postfix) with ESMTPS id 9CC553858C50
 for <libc-alpha@sourceware.org>; Mon,  2 May 2022 19:30:28 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9CC553858C50
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
 [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-628-s2IemP65NcuLIFO9be_KLA-1; Mon, 02 May 2022 15:30:25 -0400
X-MC-Unique: s2IemP65NcuLIFO9be_KLA-1
Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com
 [10.11.54.10])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A28F7101AA47;
 Mon,  2 May 2022 19:30:24 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.39.192.59])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 98FB4463E06;
 Mon,  2 May 2022 19:30:23 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: Alexey Izbyshev <izbyshev@ispras.ru>
Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
 libc-alpha@sourceware.org
Subject: Re: [PATCH] linux: Fallback to fork and exec for clone fail on
 posix_spawn (BZ#29115)
References: <20220502180605.1510951-1-adhemerval.zanella@linaro.org>
 <c5c43b6574d2c8abbb7bc2e709cb3a48@ispras.ru>
Date: Mon, 02 May 2022 21:30:21 +0200
In-Reply-To: <c5c43b6574d2c8abbb7bc2e709cb3a48@ispras.ru> (Alexey Izbyshev's
 message of "Mon, 02 May 2022 22:15:12 +0300")
Message-ID: <87mtfz4trm.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW,
 SPF_HELO_NONE, SPF_NONE, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 02 May 2022 19:30:31 -0000

* Alexey Izbyshev:

>> +      while (__write_nocancel (args->pipe[1], &ret, sizeof (ret)) <
>> 0);
>
> If the parent is killed, write() will fail with EPIPE, so this loop
> will become infinite. Maybe check for EPIPE and break?

I think we also need to do something to avoid invoking a signal handler
for SIGPIPE here.

Thanks,
Florian