From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 1DE6D3858D28 for ; Thu, 10 Feb 2022 10:54:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1DE6D3858D28 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-626-IlJPX9QxMxie6FoUztZPjQ-1; Thu, 10 Feb 2022 05:54:49 -0500 X-MC-Unique: IlJPX9QxMxie6FoUztZPjQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A49E91018720; Thu, 10 Feb 2022 10:54:48 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.193.205]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A5F976F9CE; Thu, 10 Feb 2022 10:54:47 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v2 5/5] Linux: Consolidate auxiliary vector parsing References: <151c5398adbbe538a275ea5ac77705b0abd0d748.1643886336.git.fweimer@redhat.com> <2b39ebaf-98ee-d0c2-39f6-6b0a87d0741a@linaro.org> <87v8xp3xng.fsf@oldenburg.str.redhat.com> <86eead09-64ac-b12f-4c24-ae6e4e12c4ff@linaro.org> Date: Thu, 10 Feb 2022 11:54:45 +0100 In-Reply-To: <86eead09-64ac-b12f-4c24-ae6e4e12c4ff@linaro.org> (Adhemerval Zanella's message of "Tue, 8 Feb 2022 19:57:58 -0300") Message-ID: <87mtizxa8a.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Feb 2022 10:54:53 -0000 * Adhemerval Zanella: >>>> + auxv_values[AT_PAGESZ] = EXEC_PAGESIZE; >>>> + auxv_values[AT_FPUCW] = _FPU_DEFAULT; >>>> + >>>> + /* NB: Default to a constant CONSTANT_MINSIGSTKSZ. */ >>>> + _Static_assert (__builtin_constant_p (CONSTANT_MINSIGSTKSZ), >>>> + "CONSTANT_MINSIGSTKSZ is constant"); >>> >>> Shouldn't it warn that CONSTANT_MINSIGSTKSZ is not a constant? >> >> Sorry, would please rephrase? Should I change this to >> ""CONSTANT_MINSIGSTKSZ is not constant"? > > Yeah because on a the _Static_assert failure the resulting message seems > to the opposite of what triggered it. The GCC error message doesn't suggest a strong preference either way: /tmp/t.c:1:1: error: static assertion failed: "failed" 1 | _Static_assert (0, "failed"); | ^~~~~~~~~~~~~~ I think in the existing sources, the message is sometimes indicating the failure, or what is being asserted (as is the case here). Thanks, Florian