From: Florian Weimer <fweimer@redhat.com>
To: Siddhesh Poyarekar <siddhesh@gotplt.org>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 3/4] sunrpc: Test case for clnt_create "unix" buffer overflow (bug 22542)
Date: Mon, 17 Jan 2022 10:15:13 +0100 [thread overview]
Message-ID: <87mtjuoh9a.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <bffee7ca-2d71-76bf-9788-f781e9b78cb3@gotplt.org> (Siddhesh Poyarekar's message of "Mon, 17 Jan 2022 09:05:13 +0530")
* Siddhesh Poyarekar:
> On 17/01/2022 09:01, Siddhesh Poyarekar wrote:
>> On 14/01/2022 13:54, Florian Weimer via Libc-alpha wrote:
>>> From: Martin Sebor <msebor@redhat.com>
>>>
>>> ---
>>> sunrpc/Makefile | 5 ++++-
>>> sunrpc/tst-bug22542.c | 44 +++++++++++++++++++++++++++++++++++++++++++
>>> 2 files changed, 48 insertions(+), 1 deletion(-)
>>> create mode 100644 sunrpc/tst-bug22542.c
>> LGTM.
>> Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
>
> Oh wait...
>
>>
>>>
>>> diff --git a/sunrpc/Makefile b/sunrpc/Makefile
>>> index 9a31fe48b9..183ef3dc55 100644
>>> --- a/sunrpc/Makefile
>>> +++ b/sunrpc/Makefile
>>> @@ -65,7 +65,8 @@ shared-only-routines = $(routines)
>>> endif
>>> tests = tst-xdrmem tst-xdrmem2 test-rpcent tst-udp-error
>>> tst-udp-timeout \
>>> - tst-udp-nonblocking
>>> + tst-udp-nonblocking tst-bug22542
>>> +
>>> xtests := tst-getmyaddr
>>> ifeq ($(have-thread-library),yes)
>>> @@ -110,6 +111,8 @@ $(objpfx)tst-udp-nonblocking:
>>> $(common-objpfx)linkobj/libc.so
>>> $(objpfx)tst-udp-garbage: \
>>> $(common-objpfx)linkobj/libc.so $(shared-thread-library)
>>> +$(objpfx)tst-bug22542: $(common-objpfx)linkobj/libc.so
>>> +
>>> else # !have-GLIBC_2.31
>>> routines = $(routines-for-nss)
>>> diff --git a/sunrpc/tst-bug22542.c b/sunrpc/tst-bug22542.c
>>> new file mode 100644
>>> index 0000000000..d6cd79787b
>>> --- /dev/null
>>> +++ b/sunrpc/tst-bug22542.c
>>> @@ -0,0 +1,44 @@
>>> +/* Test to verify that overlong hostname is rejected by clnt_create
>>> + and doesn't cause a buffer overflow (bug 22542).
>>> +
>>> + Copyright (C) 2022 Free Software Foundation, Inc.
>>> + This file is part of the GNU C Library.
>>> +
>>> + The GNU C Library is free software; you can redistribute it and/or
>>> + modify it under the terms of the GNU Lesser General Public
>>> + License as published by the Free Software Foundation; either
>>> + version 2.1 of the License, or (at your option) any later version.
>>> +
>>> + The GNU C Library is distributed in the hope that it will be useful,
>>> + but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
>>> + Lesser General Public License for more details.
>>> +
>>> + You should have received a copy of the GNU Lesser General Public
>>> + License along with the GNU C Library; if not, see
>>> + <http://www.gnu.org/licenses/>. */
>>> +
>>> +#include <errno.h>
>>> +#include <rpc/clnt.h>
>>> +#include <string.h>
>>> +#include <support/check.h>
>>> +#include <sys/socket.h>
>>> +#include <sys/un.h>
>>> +
>>> +static int
>>> +do_test (void)
>>> +{
>>> + /* Create an arbitrary hostname that's longer than fits in
>>> sun_path. */
>>> + char name [sizeof ((struct sockaddr_un*)0)->sun_path * 2];
>>> + memset (name, 'x', sizeof name - 1);
>>> + name [sizeof name - 1] = '\0';
>>> +
>>> + errno = 0;
>>> + CLIENT *clnt = clnt_create (name, 0, 0, "unix");
>
> Does this link? clnt_create doesn't have a default version in libc.so
> AFAICT.
It has in linkobj/libc.so:
$ eu-readelf --symbols=.dynsym linkobj/libc.so | grep clnt_create
3126: 000387a0 465 FUNC GLOBAL DEFAULT 14 clnt_create@@GLIBC_2.0
Thanks,
Florian
next prev parent reply other threads:[~2022-01-17 9:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 8:23 [PATCH v2 0/4] CVE-2022-23218, CVE-2022-23219: sunrpc buffer overflows Florian Weimer
2022-01-14 8:23 ` [PATCH 1/4] socket: Add the __sockaddr_un_set function Florian Weimer
2022-01-17 3:28 ` Siddhesh Poyarekar
2022-01-14 8:24 ` [PATCH v2 2/4] CVE-2022-23219: Buffer overflow in sunrpc clnt_create for "unix" (bug 22542) Florian Weimer
2022-01-17 3:29 ` Siddhesh Poyarekar
2022-01-14 8:24 ` [PATCH 3/4] sunrpc: Test case for clnt_create "unix" buffer overflow " Florian Weimer
2022-01-17 3:31 ` Siddhesh Poyarekar
2022-01-17 3:35 ` Siddhesh Poyarekar
2022-01-17 9:15 ` Florian Weimer [this message]
2022-01-17 9:30 ` Siddhesh Poyarekar
2022-01-17 9:32 ` Florian Weimer
2022-01-17 9:42 ` Siddhesh Poyarekar
2022-01-14 8:24 ` [PATCH v2 4/4] CVE-2022-23218: Buffer overflow in sunrpc svcunix_create (bug 28768) Florian Weimer
2022-01-17 9:43 ` Siddhesh Poyarekar
-- strict thread matches above, loose matches on Subject: below --
2022-01-12 17:00 [PATCH 0/4] Fix two sunrpc buffer overflows Florian Weimer
2022-01-12 17:01 ` [PATCH 3/4] sunrpc: Test case for clnt_create "unix" buffer overflow (bug 22542) Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtjuoh9a.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@gotplt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).