From: Andreas Schwab <schwab@linux-m68k.org>
To: "H.J. Lu via Libc-alpha" <libc-alpha@sourceware.org>
Subject: Re: [PATCH] x86-64: Use notl in EVEX strcmp [BZ #28646]
Date: Sat, 04 Dec 2021 09:14:28 +0100 [thread overview]
Message-ID: <87mtlgrdln.fsf@linux-m68k.org> (raw)
In-Reply-To: <20211204032420.3158-1-hjl.tools@gmail.com> (H. J. Lu via Libc-alpha's message of "Fri, 3 Dec 2021 19:24:20 -0800")
On Dez 03 2021, H.J. Lu via Libc-alpha wrote:
> diff --git a/sysdeps/x86_64/multiarch/strcmp-evex.S b/sysdeps/x86_64/multiarch/strcmp-evex.S
> index 0bea318abd..b68e1f7a1e 100644
> --- a/sysdeps/x86_64/multiarch/strcmp-evex.S
> +++ b/sysdeps/x86_64/multiarch/strcmp-evex.S
> @@ -646,12 +646,13 @@ L(loop_cross_page):
> in YMM3 and 32 bytes at VEC_SIZE(%rdx, %r10). */
> VPCMP $0, VEC_SIZE(%rdx, %r10), %YMM3, %k3{%k4}
> kmovd %k3, %edi
> + /* Must use notl %edi here as lower bits are for CHAR
> + comparisons potentially out of range thus can be 0 without
> + indicating mismatch. */
> + notl %edi
Spacing off in the first line.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
"And now for something completely different."
prev parent reply other threads:[~2021-12-04 8:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-04 3:24 H.J. Lu
2021-12-04 3:50 ` Noah Goldstein
2022-04-23 1:49 ` Sunil Pandey
2021-12-04 8:14 ` Andreas Schwab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtlgrdln.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).