From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id D4032385AC3E for ; Wed, 24 Nov 2021 12:03:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D4032385AC3E Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-571-VAnkixIGO4SqgBfYyRU0DA-1; Wed, 24 Nov 2021 07:03:24 -0500 X-MC-Unique: VAnkixIGO4SqgBfYyRU0DA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 17B6B1800D41; Wed, 24 Nov 2021 12:03:23 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.29]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D18142B0B8; Wed, 24 Nov 2021 12:03:21 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: Adhemerval Zanella via Libc-alpha , Samuel Thibault , Sergey Bugaev Subject: Re: [PATCH v2] io: Refactor close_range and closefrom References: <20211108172817.2235239-1-adhemerval.zanella@linaro.org> <87r1b5op82.fsf@oldenburg.str.redhat.com> Date: Wed, 24 Nov 2021 13:03:19 +0100 In-Reply-To: (Adhemerval Zanella's message of "Wed, 24 Nov 2021 08:36:16 -0300") Message-ID: <87mtltoj5k.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Nov 2021 12:03:27 -0000 * Adhemerval Zanella: >> diff --git a/sysdeps/mach/hurd/kernel-features.h b/sysdeps/mach/hurd/kernel-features.h >> index 7d4eaee0a6..5fd37a6d7b 100644 >> --- a/sysdeps/mach/hurd/kernel-features.h >> +++ b/sysdeps/mach/hurd/kernel-features.h >> @@ -19,3 +19,5 @@ >> /* This file can define __ASSUME_* macros checked by certain source files. >> Almost none of these are used outside of sysdeps/unix/sysv/linux code. >> But those referring to POSIX-level features like O_* flags can be. */ >> + >> +#define __ASSUME_CLOSE_RANGE 1 > > It does add it here (I also checked with a build for i688-gnu). Hmm, this doesn't match existing practice. We haven't unified implementations in light of such divergence, I think. If the Hurd developers don't object, it should be fine, though.. Thanks, Florian