From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id B1943385842C for ; Thu, 11 Nov 2021 08:18:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B1943385842C Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-195-6917gvLSMOGkP8v7uxZ65g-1; Thu, 11 Nov 2021 03:18:53 -0500 X-MC-Unique: 6917gvLSMOGkP8v7uxZ65g-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6103119253C7; Thu, 11 Nov 2021 08:18:52 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.82]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 545325D6B1; Thu, 11 Nov 2021 08:18:51 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella via Libc-alpha Cc: Adhemerval Zanella , leonardo.macchia@gmail.com Subject: Re: [PATCH 2/3] inet: Remove strdupa from nrl_domainname() References: <20211110185832.1931688-1-adhemerval.zanella@linaro.org> <20211110185832.1931688-3-adhemerval.zanella@linaro.org> Date: Thu, 11 Nov 2021 09:18:49 +0100 In-Reply-To: <20211110185832.1931688-3-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Wed, 10 Nov 2021 15:58:31 -0300") Message-ID: <87mtmb14wm.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Nov 2021 08:18:57 -0000 * Adhemerval Zanella via Libc-alpha: > We can use the already in place scratch_buffer. > > Checked on x86_64-linux-gnu. > --- > inet/getnameinfo.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/inet/getnameinfo.c b/inet/getnameinfo.c > index 58ebbb1154..69a94604bd 100644 > --- a/inet/getnameinfo.c > +++ b/inet/getnameinfo.c > @@ -127,10 +127,10 @@ nrl_domainname (void) > else > { > /* We need to preserve the hostname. */ > - const char *hstname = strdupa (tmpbuf.data); > - while (__gethostbyname_r (hstname, &th, > - tmpbuf.data, > - tmpbuf.length, > + size_t hstnamelen = strlen (tmpbuf.data) + 1; > + while (__gethostbyname_r (tmpbuf.data, &th, > + tmpbuf.data + hstnamelen, > + tmpbuf.length - hstnamelen, > &h, &herror)) > { > if (herror == NETDB_INTERNAL && errno == ERANGE) Can you use malloc instead? scratch_buffer_grow_preserve is a bit of an outlier in the interface. Thanks, Florian