From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <fweimer@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by sourceware.org (Postfix) with ESMTP id F03AA385E822
 for <libc-alpha@sourceware.org>; Tue,  7 Sep 2021 09:31:02 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F03AA385E822
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-448-zR27lVctOoSPTyvLYhMb4w-1; Tue, 07 Sep 2021 05:31:01 -0400
X-MC-Unique: zR27lVctOoSPTyvLYhMb4w-1
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com
 [10.5.11.12])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B6B171854E2B;
 Tue,  7 Sep 2021 09:31:00 +0000 (UTC)
Received: from oldenburg.str.redhat.com (unknown [10.39.195.4])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id A955360C9F;
 Tue,  7 Sep 2021 09:30:59 +0000 (UTC)
From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Cc: libc-alpha@sourceware.org,  Nicolas Saenz Julienne <nsaenzju@redhat.com>
Subject: Re: [PATCH 2/3] linux: Simplify get_nprocs
References: <20210906181133.1401140-1-adhemerval.zanella@linaro.org>
 <20210906181133.1401140-3-adhemerval.zanella@linaro.org>
Date: Tue, 07 Sep 2021 11:30:57 +0200
In-Reply-To: <20210906181133.1401140-3-adhemerval.zanella@linaro.org>
 (Adhemerval Zanella's message of "Mon, 6 Sep 2021 15:11:32 -0300")
Message-ID: <87mtoovijy.fsf@oldenburg.str.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain
X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW,
 RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Sep 2021 09:31:04 -0000

* Adhemerval Zanella:

> +  /* This cannot use malloc because it is used on malloc initialization.  */
> +  enum { max_num_cpus = 32768 };
> +  size_t cpu_bits_size = CPU_ALLOC_SIZE (max_num_cpus);
> +  __cpu_mask cpu_bits[cpu_bits_size / sizeof (__cpu_mask)];

I think cpu_bits_size should be an enum constant as well, to avoid
creating a VLA.

Thanks,
Florian