From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 217773858402 for ; Thu, 26 Aug 2021 12:08:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 217773858402 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-172-sV_mY1dDOgGEkAbpczdTgw-1; Thu, 26 Aug 2021 08:08:28 -0400 X-MC-Unique: sV_mY1dDOgGEkAbpczdTgw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0198A802C94; Thu, 26 Aug 2021 12:08:28 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.194.140]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4B28860CC6; Thu, 26 Aug 2021 12:08:27 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v2 02/19] nptl: Set cancellation type and state on pthread_exit References: <20210823195047.543237-1-adhemerval.zanella@linaro.org> <20210823195047.543237-3-adhemerval.zanella@linaro.org> <87pmu08s15.fsf@oldenburg.str.redhat.com> <79173390-c569-6362-7402-0c5211b719b1@linaro.org> Date: Thu, 26 Aug 2021 14:08:25 +0200 In-Reply-To: <79173390-c569-6362-7402-0c5211b719b1@linaro.org> (Adhemerval Zanella's message of "Thu, 26 Aug 2021 08:52:34 -0300") Message-ID: <87mtp476iu.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Aug 2021 12:08:43 -0000 * Adhemerval Zanella: > On 26/08/2021 06:38, Florian Weimer wrote: >> * Adhemerval Zanella: >> >>> +/* Check if a thread with PTHREAD_CANCEL_ASYNCHRONOUS cancellation on >>> + blocked read() sets the correct state and type as pthread_exit. */ >>> +static void * >>> +tf_cancel_async (void *arg) >>> +{ >>> + TEST_VERIFY (pthread_setcanceltype (PTHREAD_CANCEL_ASYNCHRONOUS, NULL) >>> + == 0); >>> + >>> + xpthread_barrier_wait (&b); >>> + >>> + pthread_cleanup_push (clh, NULL); >> >> This assumes that pthread_cleanup_push is async-cancel-safe. According >> to this thread: >> >> Async cacellation and pthread_cleanup_push >> >> >> this is not always true. >> >> Should we build this test with -fno-exceptions? > > Or I can't remove the aync test part and only test the deferred part, > I don't have a strong opinion. Testing deferred cancellation only is fine with me. Thanks, Florian