From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id BFD6E385801D for ; Sat, 27 Mar 2021 21:40:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BFD6E385801D Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-43-YirsG8b7Oh-uXA9KU-s-jQ-1; Sat, 27 Mar 2021 17:40:54 -0400 X-MC-Unique: YirsG8b7Oh-uXA9KU-s-jQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5FB59180FCA2; Sat, 27 Mar 2021 21:40:53 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-80.ams2.redhat.com [10.36.112.80]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 924A31002388; Sat, 27 Mar 2021 21:40:52 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v3 28/37] nptl: Move rwlock functions with forwarders into libc References: Date: Sat, 27 Mar 2021 22:41:18 +0100 In-Reply-To: (Adhemerval Zanella's message of "Thu, 25 Mar 2021 16:52:21 -0300") Message-ID: <87mtuoz341.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Mar 2021 21:40:57 -0000 * Adhemerval Zanella: > On 16/03/2021 14:31, Florian Weimer via Libc-alpha wrote: >> The forwarders were only used internally, so new symbol versions >> are needed. All symbols are moved at once because the forwarders >> are no-ops if libpthread is not loaded, leading to inconsistencies >> in case of a partial migration. >> >> The symbols __pthread_rwlock_rdlock, __pthread_rwlock_unlock, >> __pthread_rwlock_wrlock, pthread_rwlock_rdlock, >> pthread_rwlock_unlock, pthread_rwlock_wrlock have been moved using >> scripts/move-symbol-to-libc.py. > > LGTM, thanks (you probably want to rebase to use the compat_symbol > multiple reference support). I don't think we need the __pthread_rwlock_* exports anymore, so I have turned them into compat symbols in a revision of the patch. (There are no C11 rwlock functions.) This avoids the need for the GLIBC_2.34 symbol versions. Thanks, Florian