From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 3939E386102A for ; Fri, 23 Oct 2020 16:43:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3939E386102A Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-321-C3Xy0j6-N8mYYLzKqkxOPg-1; Fri, 23 Oct 2020 12:43:23 -0400 X-MC-Unique: C3Xy0j6-N8mYYLzKqkxOPg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C53B9107465E; Fri, 23 Oct 2020 16:43:22 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-112-111.ams2.redhat.com [10.36.112.111]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1A4769CBA0; Fri, 23 Oct 2020 16:43:21 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH 2/2] Revert "linux: Move xmknod{at} to compat symbols" References: <20201022190302.2000118-1-adhemerval.zanella@linaro.org> <20201022190302.2000118-2-adhemerval.zanella@linaro.org> <87tuukhpd5.fsf@oldenburg2.str.redhat.com> <4c312536-35ee-9ed7-e231-3bac939fefa6@linaro.org> Date: Fri, 23 Oct 2020 18:43:20 +0200 In-Reply-To: <4c312536-35ee-9ed7-e231-3bac939fefa6@linaro.org> (Adhemerval Zanella's message of "Fri, 23 Oct 2020 13:39:50 -0300") Message-ID: <87mu0chp07.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Oct 2020 16:43:27 -0000 * Adhemerval Zanella: > On 23/10/2020 13:35, Florian Weimer wrote: >> * Adhemerval Zanella: >>=20 >>> This reverts commit 81b83ff61f95f30ad53d6075247af0ea61a0b16e responsibl= e >>> to make both __xmknod{at} compatible symbols. >>> >>> The idea is to not force static libraries built against old glibc >>> to update against new glibcs (since they reference the the >>> xmknod{at} symbols). >>=20 >> I think it's not correct to label this as a revert in the Git sense. >> At best it's a partial revert. I tried first to verify this as an >> actual revert and was wondering if I got the diffing wrong. > > Ok, I will change to a partial remove. > >>=20 >> I think you need to remove libc_hidden_def and libc_hidden_proto around >> __xmknod, __xmknodat. =E2=80=9Cgit grep 'libc_hidden.*__xmknod'=E2=80= =9D should not >> return anything. Maybe that should be a separate patch. > > If I recall correctly they are still required for Hurd, but I double > check. In fact I think we should remove all the io/*xstat* and > io/*xmknod* since there is no point in providing them as generic > interfaces. Then I think you should add the missing libc_hidden_defs instead (to the Linux implementations). The present state is inconsistent and potentially brittle. Thanks, Florian --=20 Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'N= eill