From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id C8C9A3858D35 for ; Wed, 24 Jun 2020 19:24:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C8C9A3858D35 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-499-uucXm7f8Nme8dccQphk9QQ-1; Wed, 24 Jun 2020 15:24:25 -0400 X-MC-Unique: uucXm7f8Nme8dccQphk9QQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5A65A804003; Wed, 24 Jun 2020 19:24:23 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-113-18.ams2.redhat.com [10.36.113.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 485145C1BB; Wed, 24 Jun 2020 19:24:17 +0000 (UTC) From: Florian Weimer To: Mathieu Desnoyers Cc: carlos , Joseph Myers , Szabolcs Nagy , libc-alpha , Thomas Gleixner , Ben Maurer , Peter Zijlstra , Paul , Boqun Feng , Will Deacon , Dave Watson , Paul Turner , Rich Felker , linux-kernel , linux-api Subject: Re: [PATCH 1/3] glibc: Perform rseq registration at C startup and thread creation (v21) References: <20200622180803.1449-1-mathieu.desnoyers@efficios.com> <20200622180803.1449-2-mathieu.desnoyers@efficios.com> <87d05obl4w.fsf@oldenburg2.str.redhat.com> <1158112159.11628.1593025203438.JavaMail.zimbra@efficios.com> <87r1u48eix.fsf@oldenburg2.str.redhat.com> <1248023868.11643.1593026198678.JavaMail.zimbra@efficios.com> Date: Wed, 24 Jun 2020 21:24:15 +0200 In-Reply-To: <1248023868.11643.1593026198678.JavaMail.zimbra@efficios.com> (Mathieu Desnoyers's message of "Wed, 24 Jun 2020 15:16:38 -0400 (EDT)") Message-ID: <87mu4s8dy8.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jun 2020 19:24:31 -0000 * Mathieu Desnoyers: >> I think we should keep things simple on the glibc side for now and do >> this changes to the kernel headers first. > > Just to be sure I understand what you mean by "keep things simple", do you > recommend removing the following lines completely for now from sys/rseq.h ? > > /* Ensure the compiler supports rseq_align. */ > __rseq_static_assert (__rseq_alignof (struct rseq_cs) >= 32, "alignment"); > __rseq_static_assert (__rseq_alignof (struct rseq) >= 32, "alignment"); Yes, that's what I meant. Thanks, Florian