From: Florian Weimer <fw@deneb.enyo.de>
To: Samuel Thibault <samuel.thibault@gnu.org>
Cc: libc-alpha@sourceware.org, commit-hurd@gnu.org
Subject: Re: [hurd,commited 2/2] x86 tls: Use _Static_assert for TLS access size assertion
Date: Mon, 17 Feb 2020 12:25:00 -0000 [thread overview]
Message-ID: <87mu9hcshk.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <20200217115227.x3y6sqm6f7eg42gl@function> (Samuel Thibault's message of "Mon, 17 Feb 2020 12:52:27 +0100")
* Samuel Thibault:
> Florian Weimer, le lun. 17 févr. 2020 10:41:49 +0100, a ecrit:
>> > ---
>> > sysdeps/i386/nptl/tls.h | 46 ++++++++++++++++--------------------
>> > sysdeps/mach/hurd/i386/tls.h | 46 ++++++++++++++++--------------------
>> > sysdeps/x86_64/nptl/tls.h | 46 ++++++++++++++++--------------------
>> > 3 files changed, 60 insertions(+), 78 deletions(-)
>> >
>> > diff --git a/sysdeps/i386/nptl/tls.h b/sysdeps/i386/nptl/tls.h
>> > index ffead90857..28053a77f3 100644
>> > --- a/sysdeps/i386/nptl/tls.h
>> > +++ b/sysdeps/i386/nptl/tls.h
>> > @@ -255,6 +255,9 @@ tls_fill_user_desc (union user_desc_init *desc,
>> > /* Read member of the thread descriptor directly. */
>> > # define THREAD_GETMEM(descr, member) \
>> > ({ __typeof (descr->member) __value; \
>> > + _Static_assert (sizeof (__value) == 1 \
>> > + || sizeof (__value) == 4 \
>> > + || sizeof (__value) == 8); \
>> > if (sizeof (__value) == 1) \
>>
>> This (and the other changes) broke the x86_64-linux-gnu build.
>
> Uh?
>
> It built successfully on my box, I wonder what difference we have.
I think single-argument _Static_assert is only available with GCC 9
and later.
prev parent reply other threads:[~2020-02-17 12:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 0:20 [hurd,commited 1/2] htl: Link internal htl tests against libpthread Samuel Thibault
2020-02-17 0:20 ` [hurd,commited 2/2] x86 tls: Use _Static_assert for TLS access size assertion Samuel Thibault
2020-02-17 9:43 ` Florian Weimer
2020-02-17 11:52 ` Samuel Thibault
2020-02-17 12:25 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mu9hcshk.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=commit-hurd@gnu.org \
--cc=libc-alpha@sourceware.org \
--cc=samuel.thibault@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).