From: Florian Weimer <fw@deneb.enyo.de>
To: Samuel Thibault <samuel.thibault@gnu.org>
Cc: libc-alpha@sourceware.org, commit-hurd@gnu.org
Subject: Re: [hurd,commited 1/3] hurd: Fix ld.so link
Date: Sun, 01 Dec 2019 19:16:00 -0000 [thread overview]
Message-ID: <87mucbdfff.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <20191201190155.qpw4ilcixnjwtl5v@function> (Samuel Thibault's message of "Sun, 1 Dec 2019 20:01:55 +0100")
* Samuel Thibault:
> Florian Weimer, le dim. 01 déc. 2019 19:58:51 +0100, a ecrit:
>> > diff --git a/sysdeps/mach/hurd/Versions b/sysdeps/mach/hurd/Versions
>> > index f69d5fef67..cd148c820f 100644
>> > --- a/sysdeps/mach/hurd/Versions
>> > +++ b/sysdeps/mach/hurd/Versions
>> > @@ -1,7 +1,7 @@
>> > libc {
>> > GLIBC_2.0 {
>> > # functions with a weak definition in the dynamic linker
>> > - __access; __getcwd; __mmap;
>> > + __access; __getcwd; __mmap; __sigprocmask;
>> > }
>>
>> I think I missed the libc update in the patch I posted. But this is
>> wrong, you need to add it to GLIBC_PRIVATE for both libc and ld.
>> Then there will be no abilist update, as expected.
>
> Then it's not only for that symbol, but others from dl-sysdep.c: I just
> followed what was done for the others.
That may be so, but we cannot change the symbol sets for historic
releases. If you really want to use a non-private symbol, it would
have to be at version GLIBC_2.31. But given that it's an internal
interface, GLIBC_PRIVATE is the proper choice.
(Initially, GLIBC_PRIVATE was not used for internal symbols.)
next prev parent reply other threads:[~2019-12-01 19:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-01 18:53 [hurd,commited 0/3] fixes for hurd port Samuel Thibault
2019-12-01 18:53 ` [hurd,commited 3/3] hurd: Fix renameat2 error Samuel Thibault
2019-12-01 18:53 ` [hurd,commited 2/3] hurd: make strerror(0) coherent with other ports Samuel Thibault
2019-12-01 18:53 ` [hurd,commited 1/3] hurd: Fix ld.so link Samuel Thibault
2019-12-01 18:58 ` Florian Weimer
2019-12-01 19:02 ` Samuel Thibault
2019-12-01 19:16 ` Florian Weimer [this message]
2019-12-01 20:05 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mucbdfff.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=commit-hurd@gnu.org \
--cc=libc-alpha@sourceware.org \
--cc=samuel.thibault@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).