From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96956 invoked by alias); 1 Dec 2019 19:16:56 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 96948 invoked by uid 89); 1 Dec 2019 19:16:56 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-16.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy=Florian, HX-Languages-Length:1148 X-HELO: albireo.enyo.de From: Florian Weimer To: Samuel Thibault Cc: libc-alpha@sourceware.org, commit-hurd@gnu.org Subject: Re: [hurd,commited 1/3] hurd: Fix ld.so link References: <20191201185306.1159853-1-samuel.thibault@ens-lyon.org> <20191201185306.1159853-2-samuel.thibault@ens-lyon.org> <87r21ndg9g.fsf@mid.deneb.enyo.de> <20191201190155.qpw4ilcixnjwtl5v@function> Date: Sun, 01 Dec 2019 19:16:00 -0000 In-Reply-To: <20191201190155.qpw4ilcixnjwtl5v@function> (Samuel Thibault's message of "Sun, 1 Dec 2019 20:01:55 +0100") Message-ID: <87mucbdfff.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2019-12/txt/msg00011.txt.bz2 * Samuel Thibault: > Florian Weimer, le dim. 01 d=E9c. 2019 19:58:51 +0100, a ecrit: >> > diff --git a/sysdeps/mach/hurd/Versions b/sysdeps/mach/hurd/Versions >> > index f69d5fef67..cd148c820f 100644 >> > --- a/sysdeps/mach/hurd/Versions >> > +++ b/sysdeps/mach/hurd/Versions >> > @@ -1,7 +1,7 @@ >> > libc { >> > GLIBC_2.0 { >> > # functions with a weak definition in the dynamic linker >> > - __access; __getcwd; __mmap; >> > + __access; __getcwd; __mmap; __sigprocmask; >> > } >>=20 >> I think I missed the libc update in the patch I posted. But this is >> wrong, you need to add it to GLIBC_PRIVATE for both libc and ld. >> Then there will be no abilist update, as expected. > > Then it's not only for that symbol, but others from dl-sysdep.c: I just > followed what was done for the others. That may be so, but we cannot change the symbol sets for historic releases. If you really want to use a non-private symbol, it would have to be at version GLIBC_2.31. But given that it's an internal interface, GLIBC_PRIVATE is the proper choice. (Initially, GLIBC_PRIVATE was not used for internal symbols.)