From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81132 invoked by alias); 26 Jul 2018 19:38:53 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 81122 invoked by uid 89); 26 Jul 2018 19:38:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=H*Ad:D*ucla.edu, H*M:home, H*MI:home X-HELO: mx1.suse.de From: Andreas Schwab To: Florian Weimer Cc: Szabolcs Nagy , nd@arm.com, Carlos O'Donell , Paul Eggert , libc-alpha@sourceware.org Subject: Re: [PATCH] Add the statx function References: <20180630224103.4501543994575@oldenburg.str.redhat.com> <4934579e-a05c-3dcc-0b26-5ec09e03fbb3@cs.ucla.edu> <39950c72-09e7-4557-d62f-4b3a65ec5353@redhat.com> <9378e999-9c2b-0925-89e0-d9c39101b1bf@redhat.com> <85b41fe2-05f1-094d-c9c2-f3149e4dce83@redhat.com> <9f8fcf2b-a075-a390-90a5-d8f5cd38f65c@arm.com> X-Yow: Hello? Enema Bondage? I'm calling because I want to be happy, I guess.. Date: Thu, 26 Jul 2018 19:38:00 -0000 In-Reply-To: (Florian Weimer's message of "Thu, 26 Jul 2018 17:16:09 +0200") Message-ID: <87muudss6x.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2018-07/txt/msg00918.txt.bz2 On Jul 26 2018, Florian Weimer wrote: > On 07/11/2018 12:01 PM, Szabolcs Nagy wrote: >> On 11/07/18 07:55, Florian Weimer wrote: >>> On 07/11/2018 08:53 AM, Andreas Schwab wrote: >>>> /usr/include/sys/stat.h:446:11: fatal error: bits/statx.h: No such >>>> file or directory >>>>   # include >>>>             ^~~~~~~~~~~~~~ >>> >>> Okay, so this file should be an installed header.  I will commit a fix >>> after testing. >>> >>> Any idea why our header tests do not catch this? >>> >> >> because the glibc source tree does have bits/statx.h >> and all tests (incorrectly) run with internal headers >> in the include path (not just the installed ones). > > I had hoped that the check-installed-headers-* tests would catch this, but > clearly that's not the case. > >> build-many-glibcs.py catches it though when building gcc >> (i've just run into this). > > Only if GCC uses the header, right? So it's only limited coverage because > GCC aims to be portable and won't use obscure stuff. isn't obscure. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."