From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18151 invoked by alias); 30 Mar 2017 20:55:58 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 18135 invoked by uid 89); 30 Mar 2017 20:55:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=H*r:TLS1.2, H*r:4.88 X-HELO: albireo.enyo.de From: Florian Weimer To: Adhemerval Zanella Cc: Wainer dos Santos Moschetta , libc-alpha@sourceware.org Subject: Re: [PATCH] Update elf tests to use the support test driver. References: <20170329151407.6476-1-wainersm@linux.vnet.ibm.com> <32f6acde-964a-172d-43d7-69514932aaba@linaro.org> Date: Thu, 30 Mar 2017 20:55:00 -0000 In-Reply-To: <32f6acde-964a-172d-43d7-69514932aaba@linaro.org> (Adhemerval Zanella's message of "Thu, 30 Mar 2017 17:52:35 -0300") Message-ID: <87mvc2scv8.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2017-03/txt/msg00708.txt.bz2 * Adhemerval Zanella: > There is no need to remove the static definition from this function and > for all other every tests which includes the test-driver.c (since it will > end up creating the main entrypoint anyway). I would avoid change it. Agreed. The corresponding ChangeLog bit looks a bit strange as well: * elf/next.c: Import support/test-driver.c instead of test-skeleton.c and delete TEST_FUNCTION macro definition. (do_test): adjust return attribute. * elf/nodelete.c: Likewise. I don't think any function attribute is changed in the patch.