From: Florian Weimer <fweimer@redhat.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: Jonathan Wakely <jwakely@redhat.com>,
Szabolcs Nagy <szabolcs.nagy@arm.com>,
Rich Felker <dalias@libc.org>,
Paul Pluzhnikov via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [patch] Use __builtin_FILE and __builtin_LINE in assert implementation in C++
Date: Sun, 05 Feb 2023 23:34:17 +0100 [thread overview]
Message-ID: <87o7q7wxli.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <CALoOobOrLfwEU=ABXD9Z_ajbP+sbmD6RcmXSb1aRo8gx2cyzZQ@mail.gmail.com> (Paul Pluzhnikov's message of "Sun, 5 Feb 2023 13:51:25 -0800")
* Paul Pluzhnikov:
> +# if __has_builtin(__builtin_FILE)
> +# define __ASSERT_FILE __builtin_FILE()
> +# define __ASSERT_LINE __builtin_LINE()
> +# else
> +# define __ASSERT_FILE __FILE__
> +# define __ASSERT_LINE __LINE__
> +# endif
__has_builtin itself needs to be conditionalized. 8-(
Please use __glibc_assert_file or something like that. __ASSERT_FILE
sounds like something someone else might use (although it's in the
implementation namespace).
I think the general direction is fine.
Thanks,
Florian
next prev parent reply other threads:[~2023-02-05 22:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 19:28 Paul Pluzhnikov
2023-01-23 14:26 ` Florian Weimer
2023-01-24 11:10 ` Rich Felker
2023-01-24 11:19 ` Rich Felker
2023-01-24 11:19 ` Florian Weimer
2023-01-24 11:23 ` Rich Felker
2023-01-24 11:53 ` Jonathan Wakely
2023-01-24 12:08 ` Florian Weimer
2023-01-24 12:17 ` Jonathan Wakely
2023-01-24 15:07 ` Szabolcs Nagy
2023-01-24 15:51 ` Jonathan Wakely
2023-01-26 19:18 ` Paul Pluzhnikov
2023-01-27 15:43 ` Jonathan Wakely
2023-02-05 18:39 ` Paul Pluzhnikov
2023-02-05 20:08 ` Florian Weimer
2023-02-05 21:51 ` Paul Pluzhnikov
2023-02-05 22:34 ` Florian Weimer [this message]
2023-02-05 22:55 ` Paul Pluzhnikov
2023-02-06 6:01 ` Florian Weimer
2023-02-06 16:25 ` Paul Pluzhnikov
2023-02-08 21:43 ` Paul Pluzhnikov
2023-01-25 20:50 ` Paul Pluzhnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7q7wxli.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=dalias@libc.org \
--cc=jwakely@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=ppluzhnikov@google.com \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).