From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 1BF5B3858D1E for ; Thu, 10 Nov 2022 20:42:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1BF5B3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668112925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rWvhc8flULOo+IwZc77Hg/8oswisnt/Qax+7kEJYCus=; b=GQDStH8y1NRT1gpxJZz6fUh97bz3pQoLyx4/0IKtYQgi/stInQULnbP1z4l1Rl3umtUdlB UMxkHtemuzkGIO4XgoE6sD/ORJTSdBUAKzxSX874sk9Lofjec6p0i9UDshkDfcv2/B1ctL GPnpq81FMxYP0QGLAfJYdYqomGX3Hp8= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-616-iBhF2kAzP92SsktGbl72Ng-1; Thu, 10 Nov 2022 15:42:02 -0500 X-MC-Unique: iBhF2kAzP92SsktGbl72Ng-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6D1F638035A0; Thu, 10 Nov 2022 20:42:02 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.193.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 965E5C15BA8; Thu, 10 Nov 2022 20:42:01 +0000 (UTC) From: Florian Weimer To: "H.J. Lu" Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] Linux: Support non-variadic calls to prctl (bug 29770) References: <878rkiu72f.fsf@oldenburg.str.redhat.com> Date: Thu, 10 Nov 2022 21:41:59 +0100 In-Reply-To: (H. J. Lu's message of "Thu, 10 Nov 2022 12:34:37 -0800") Message-ID: <87o7ter17s.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * H. J. Lu: >> diff --git a/sysdeps/mips/dl-machine-reject-phdr.h b/sysdeps/mips/dl-machine-reject-phdr.h >> index 45b6bcaeac..7efd5fc92b 100644 >> --- a/sysdeps/mips/dl-machine-reject-phdr.h >> +++ b/sysdeps/mips/dl-machine-reject-phdr.h >> @@ -169,7 +169,7 @@ elf_machine_reject_phdr_p (const ElfW(Phdr) *phdr, unsigned int phnum, >> bool cannot_mode_switch = false; >> >> /* Get the current hardware mode. */ >> - cur_mode = __prctl (PR_GET_FP_MODE); >> + cur_mode = __prctl (PR_GET_FP_MODE, 0, 0, 0, 0); > > Can it use INLINE_SYSCALL_CALL here? Probably, should be included by this point. I can't run this code for testing, so I tried to make minimal changes. Thanks, Florian