* [PATCH] Linux: Remove exit system call from _exit
@ 2022-08-03 15:53 Florian Weimer
2022-08-03 16:58 ` H.J. Lu
0 siblings, 1 reply; 2+ messages in thread
From: Florian Weimer @ 2022-08-03 15:53 UTC (permalink / raw)
To: libc-alpha
exit only terminates the current thread, not the whole process, so it
is the wrong fallback system call in this context. All supported
Linux versions implement the exit_group system call anyway.
---
sysdeps/unix/sysv/linux/_exit.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sysdeps/unix/sysv/linux/_exit.c b/sysdeps/unix/sysv/linux/_exit.c
index 7ad3e0aae4..f916d97ae2 100644
--- a/sysdeps/unix/sysv/linux/_exit.c
+++ b/sysdeps/unix/sysv/linux/_exit.c
@@ -28,7 +28,6 @@ _exit (int status)
while (1)
{
INLINE_SYSCALL (exit_group, 1, status);
- INLINE_SYSCALL (exit, 1, status);
#ifdef ABORT_INSTRUCTION
ABORT_INSTRUCTION;
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] Linux: Remove exit system call from _exit
2022-08-03 15:53 [PATCH] Linux: Remove exit system call from _exit Florian Weimer
@ 2022-08-03 16:58 ` H.J. Lu
0 siblings, 0 replies; 2+ messages in thread
From: H.J. Lu @ 2022-08-03 16:58 UTC (permalink / raw)
To: Florian Weimer; +Cc: GNU C Library
On Wed, Aug 3, 2022 at 8:53 AM Florian Weimer via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> exit only terminates the current thread, not the whole process, so it
> is the wrong fallback system call in this context. All supported
> Linux versions implement the exit_group system call anyway.
>
> ---
> sysdeps/unix/sysv/linux/_exit.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sysdeps/unix/sysv/linux/_exit.c b/sysdeps/unix/sysv/linux/_exit.c
> index 7ad3e0aae4..f916d97ae2 100644
> --- a/sysdeps/unix/sysv/linux/_exit.c
> +++ b/sysdeps/unix/sysv/linux/_exit.c
> @@ -28,7 +28,6 @@ _exit (int status)
> while (1)
> {
> INLINE_SYSCALL (exit_group, 1, status);
> - INLINE_SYSCALL (exit, 1, status);
>
> #ifdef ABORT_INSTRUCTION
> ABORT_INSTRUCTION;
>
LGTM.
Thanks.
--
H.J.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-03 16:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-03 15:53 [PATCH] Linux: Remove exit system call from _exit Florian Weimer
2022-08-03 16:58 ` H.J. Lu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).