From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id BEDFC3858D35 for ; Tue, 16 Nov 2021 13:15:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BEDFC3858D35 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-87-54DPMRtZOmeBqwG9q8C1CA-1; Tue, 16 Nov 2021 08:15:35 -0500 X-MC-Unique: 54DPMRtZOmeBqwG9q8C1CA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4CA7F800493; Tue, 16 Nov 2021 13:15:34 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.194.81]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E1573694B4; Tue, 16 Nov 2021 13:15:30 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org, John Mellor-Crummey , Ben Woodard Subject: Re: [PATCH v6 01/20] elf: Suppress audit calls when a (new) namespace is empty (BZ #28062) References: <20211115183734.531155-1-adhemerval.zanella@linaro.org> <20211115183734.531155-2-adhemerval.zanella@linaro.org> <87ee7hfdk7.fsf@oldenburg.str.redhat.com> <37adfe77-f066-8046-2fe4-5026d3bdac1c@linaro.org> Date: Tue, 16 Nov 2021 14:15:28 +0100 In-Reply-To: <37adfe77-f066-8046-2fe4-5026d3bdac1c@linaro.org> (Adhemerval Zanella's message of "Tue, 16 Nov 2021 10:14:00 -0300") Message-ID: <87o86kckcv.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Nov 2021 13:15:40 -0000 * Adhemerval Zanella: > On 15/11/2021 16:01, Florian Weimer wrote: >> * Adhemerval Zanella: >> >>> For a new Lmid_t the namespace link_map list are empty, so it requires >>> to check if before using it. This can happen for when audit module >>> is used along with dlmopen. >> >> Looks like you forgot to update the commit message. > > Indeed, the title is also misleading. I have changed to: > > elf: Move la_activity (LA_ACT_ADD) after _dl_add_to_namespace_list() (BZ #28062) > > It ensures that the the namespace is guaranteed to not be empty. Looks good with these changes. Reviewed-by: Florian Weimer Thanks, Florian