From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id E4F553990C33 for ; Wed, 28 Jul 2021 11:25:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E4F553990C33 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-383-eXPz93aPOrWicSTTnLO-9w-1; Wed, 28 Jul 2021 07:25:20 -0400 X-MC-Unique: eXPz93aPOrWicSTTnLO-9w-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2EA18DF8A0; Wed, 28 Jul 2021 11:25:19 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-7.ams2.redhat.com [10.36.112.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5606660BD9; Wed, 28 Jul 2021 11:25:18 +0000 (UTC) From: Florian Weimer To: Siddhesh Poyarekar Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v2] xmalloc: Fix warnings with gcc analyzer References: <20210728103345.4065595-1-siddhesh@sourceware.org> <87sfzy8zcv.fsf@oldenburg.str.redhat.com> <6285ea15-68a1-38a0-712c-f47188275951@sourceware.org> Date: Wed, 28 Jul 2021 13:25:16 +0200 In-Reply-To: <6285ea15-68a1-38a0-712c-f47188275951@sourceware.org> (Siddhesh Poyarekar's message of "Wed, 28 Jul 2021 16:53:34 +0530") Message-ID: <87o8am8yub.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=unavailable autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jul 2021 11:25:22 -0000 * Siddhesh Poyarekar: > On 7/28/21 4:44 PM, Florian Weimer via Libc-alpha wrote: >> * Siddhesh Poyarekar: >> >>> extern void *xrealloc (void *o, size_t n) >>> + __attribute_malloc__ __attribute_alloc_size__ ((2)) __attr_dealloc_free >>> + __returns_nonnull; >> Sorry, this one has again __returns_nonnull for xrealloc. > > The xrealloc in programs does a malloc(1) if the size requested is 0, > so it never really returns a NULL. So it does not free anything ever? We should not have two different attributes for xrealloc. I suggest to drop the attribute from the include/* version for now, until we can clean this up. Thanks, Florian