From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 103573851C14 for ; Wed, 14 Jul 2021 11:57:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 103573851C14 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-133-l81CUQU2NC2Vrrc-62-O8A-1; Wed, 14 Jul 2021 07:57:44 -0400 X-MC-Unique: l81CUQU2NC2Vrrc-62-O8A-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 590838042FE for ; Wed, 14 Jul 2021 11:57:43 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-113-59.ams2.redhat.com [10.36.113.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 09D2710372DC; Wed, 14 Jul 2021 11:57:38 +0000 (UTC) From: Florian Weimer To: Carlos O'Donell Cc: libc-alpha@sourceware.org Subject: C.UTF-8 review Date: Wed, 14 Jul 2021 13:57:37 +0200 Message-ID: <87o8b5ds5q.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jul 2021 11:57:47 -0000 Carlos, I reviewed your changes on the codonell/c-utf8 branch and have some comments. I believe the replacement character should U+FFFD REPLACEMENT CHARACTER, not U+003F QUESTION MARK: +% Include the neutral transliterations. The builtin C and +% POSIX locales have +1600 transliterations that are built into +% the locales, and these are a superset of those. +translit_start +include "translit_neutral";"" +default_missing +translit_end I guess this menas that C and C.UTF-8 LC_CTYPE diverge. The strcmp_collation keyword is reasonably explicit. I would appreciate if we could produce an error if it is used along with other collation directives. Right now, those are silently ignored. There is a trailing newline in localedata/locales/C. But overall it's very nice. We should have shipped this many years ago. Thanks, Florian