From: Florian Weimer <fweimer@redhat.com>
To: Siddhesh Poyarekar <siddhesh@sourceware.org>
Cc: Siddhesh Poyarekar via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] elf/tests: Make thrlock and noload depend on libm
Date: Thu, 08 Jul 2021 07:46:53 +0200 [thread overview]
Message-ID: <87o8bdz7aq.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <b93c9da7-d69e-90e6-e554-12236853e403@sourceware.org> (Siddhesh Poyarekar's message of "Wed, 7 Jul 2021 22:52:00 +0530")
* Siddhesh Poyarekar:
> On 7/7/21 10:36 PM, Florian Weimer via Libc-alpha wrote:
>> * Siddhesh Poyarekar via Libc-alpha:
>>
>>> Both tests try to dlopen libm.so at runtime, so make them depend on it
>>> to avoid running before libm.so is built.
>> Can that really happen in the current build system?
>
> I don't the exact sequence of events, but I did run into this a few
> minutes ago, which is how I realized there was a missing dependency.
> The tests failed with "file too short", which was probably them racing
> with the static linker linking libm.so.
Hmm. I would expect that recursive make running in elf subdirectory
simply does not have the knowledge how to link libm properly. And it
will definitely not do that while running tests.
Thanks,
Florian
next prev parent reply other threads:[~2021-07-08 5:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 16:58 Siddhesh Poyarekar
2021-07-07 17:06 ` Florian Weimer
2021-07-07 17:22 ` Siddhesh Poyarekar
2021-07-08 5:46 ` Florian Weimer [this message]
2021-07-08 6:01 ` Siddhesh Poyarekar
2021-07-08 6:09 ` Florian Weimer
2021-07-08 6:12 ` Siddhesh Poyarekar
2021-07-08 6:15 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8bdz7aq.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).