From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id A1E093839C68 for ; Thu, 8 Jul 2021 05:47:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A1E093839C68 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-441-bRCHbmS0OPWhV-O-eRHk2w-1; Thu, 08 Jul 2021 01:46:57 -0400 X-MC-Unique: bRCHbmS0OPWhV-O-eRHk2w-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6DD7F10C1ADC; Thu, 8 Jul 2021 05:46:56 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-115-5.ams2.redhat.com [10.36.115.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 92B4119D7C; Thu, 8 Jul 2021 05:46:55 +0000 (UTC) From: Florian Weimer To: Siddhesh Poyarekar Cc: Siddhesh Poyarekar via Libc-alpha Subject: Re: [PATCH] elf/tests: Make thrlock and noload depend on libm References: <20210707165859.2993732-1-siddhesh@sourceware.org> <87im1m2gvy.fsf@oldenburg.str.redhat.com> Date: Thu, 08 Jul 2021 07:46:53 +0200 In-Reply-To: (Siddhesh Poyarekar's message of "Wed, 7 Jul 2021 22:52:00 +0530") Message-ID: <87o8bdz7aq.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jul 2021 05:47:02 -0000 * Siddhesh Poyarekar: > On 7/7/21 10:36 PM, Florian Weimer via Libc-alpha wrote: >> * Siddhesh Poyarekar via Libc-alpha: >> >>> Both tests try to dlopen libm.so at runtime, so make them depend on it >>> to avoid running before libm.so is built. >> Can that really happen in the current build system? > > I don't the exact sequence of events, but I did run into this a few > minutes ago, which is how I realized there was a missing dependency. > The tests failed with "file too short", which was probably them racing > with the static linker linking libm.so. Hmm. I would expect that recursive make running in elf subdirectory simply does not have the knowledge how to link libm properly. And it will definitely not do that while running tests. Thanks, Florian