From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 991043846034 for ; Fri, 21 May 2021 19:17:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 991043846034 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-214-TdSBAXJWMPO_Lp8ThK8Dog-1; Fri, 21 May 2021 15:17:03 -0400 X-MC-Unique: TdSBAXJWMPO_Lp8ThK8Dog-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C244C8015F8 for ; Fri, 21 May 2021 19:17:02 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-113-228.ams2.redhat.com [10.36.113.228]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 288545D6DC for ; Fri, 21 May 2021 19:17:01 +0000 (UTC) From: Florian Weimer To: Florian Weimer via Libc-alpha Subject: Re: [PATCH 00/14] Move libdl into libc References: Date: Fri, 21 May 2021 21:17:00 +0200 In-Reply-To: (Florian Weimer via Libc-alpha's message of "Wed, 19 May 2021 20:03:34 +0200") Message-ID: <87o8d36gnn.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 May 2021 19:17:08 -0000 * Florian Weimer via Libc-alpha: > This patch series removes all code from libdl.so.2. I have not removed > the shared object itself because I want to mirror what we are doing for > libpthread, and the discussion there is still ongoing. > > There is an oddity because for several targets, the baseline ABI version > for libdl is GLIBC_2.0 and not GLIBC_2.2. This cannot be expressed with > the existing Versions framework. Since the affected targets are more or > less on the way out anyway (hppa, ia64, sh, sparc64), I didn't > overdesign the solution and emitted the required version nodes directly > in scripts/versions.awk. > > This move also happens on Hurd because the implementation isn't > separate. > > This fixes a POSIX conformance issue with the c99 command because POSIX > requires that dlopen etc. are available without -ldl. > > Tested on i386-linux-gnu and x86_64-linux-gnu. Built with > build-many-glibcs.py (including most intermediate steps). I should have mentioned that I'm removing the strange double-build with those dlfcn/sdl*.c files. This is why the files have somewhat different layout after the move. I do not see any value in the dlfcn/sdl*.c construct. The new version relies on compiler inlining to remove redudant functions. Thanks, Florian