From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id DFA2B385481F for ; Wed, 17 Mar 2021 20:13:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DFA2B385481F Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-455-lotv_zLTOFiK6M52zuQSjQ-1; Wed, 17 Mar 2021 16:12:59 -0400 X-MC-Unique: lotv_zLTOFiK6M52zuQSjQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C25B31013720 for ; Wed, 17 Mar 2021 20:12:58 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-115-121.ams2.redhat.com [10.36.115.121]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2A57C5D6AC for ; Wed, 17 Mar 2021 20:12:57 +0000 (UTC) From: Florian Weimer To: Florian Weimer via Libc-alpha Subject: Re: [PATCH 08/30] nptl: Remove send from libpthread References: <20210316200510.2135405-1-adhemerval.zanella@linaro.org> <20210316200510.2135405-9-adhemerval.zanella@linaro.org> <878s6l1wnl.fsf@oldenburg.str.redhat.com> Date: Wed, 17 Mar 2021 21:13:04 +0100 In-Reply-To: <878s6l1wnl.fsf@oldenburg.str.redhat.com> (Florian Weimer via Libc-alpha's message of "Wed, 17 Mar 2021 19:07:42 +0100") Message-ID: <87o8fhwncf.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Mar 2021 20:13:06 -0000 * Florian Weimer via Libc-alpha: > * Adhemerval Zanella via Libc-alpha: > >> The libc version is identical and built with same flags. Both aarch64 >> and nios2 also requires to export __send. It was done previously with >> the HAVE_INTERNAL_SEND_SYMBOL (which forced the symbol creation), >> however it is simpler to add them on the architecture specific Version >> script snippet. > > In other cases, we have said that doing this would require adding a > __send@GLIBC_2.34 symbol (which is what my patched > move-symbol-to-libc.py script does). > > However, I think we can turn this into a compat symbol in this case. > All __send callers are internal to libc, so we don't need > __send@GLIBC_PRIVATE, just a hidden proto. One more comment: Please also remove: sysdeps/unix/sysv/linux/aarch64/sysdep.h:# undef HAVE_INTERNAL_SEND_SYMBOL sysdeps/unix/sysv/linux/nios2/sysdep.h:# undef HAVE_INTERNAL_SEND_SYMBOL Thanks, Florian