From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 5B162384C005 for ; Wed, 17 Mar 2021 19:33:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5B162384C005 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-422-y_6OsmPFOba8DVUu2RXfNg-1; Wed, 17 Mar 2021 15:33:12 -0400 X-MC-Unique: y_6OsmPFOba8DVUu2RXfNg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 51241107ACCD; Wed, 17 Mar 2021 19:33:11 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-115-121.ams2.redhat.com [10.36.115.121]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 75D555C1CF; Wed, 17 Mar 2021 19:33:10 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH 15/30] nptl: Remove pread from libpthread References: <20210316200510.2135405-1-adhemerval.zanella@linaro.org> <20210316200510.2135405-16-adhemerval.zanella@linaro.org> Date: Wed, 17 Mar 2021 20:33:15 +0100 In-Reply-To: <20210316200510.2135405-16-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Tue, 16 Mar 2021 17:04:55 -0300") Message-ID: <87o8fhy3r8.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Mar 2021 19:33:16 -0000 * Adhemerval Zanella via Libc-alpha: > diff --git a/sysdeps/unix/sysv/linux/alpha/pread64.c b/sysdeps/unix/sysv/linux/alpha/pread64.c > new file mode 100644 > index 0000000000..a40e4447e1 > --- /dev/null > +++ b/sysdeps/unix/sysv/linux/alpha/pread64.c > @@ -0,0 +1,33 @@ > +/* Read from to a file descriptor at a given offset. Linux/alpha version. > + Copyright (C) 2021 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#define PREAD64_REQUIRE_PREAD_COMPAT > +#include > + > +/* libpthread compat symbols. */ > +# if SHLIB_COMPAT (libc, GLIBC_2_1, GLIBC_2_2) > +strong_alias (__libc_pread64, __compat_pread) > +compat_symbol (libc, __compat_pread, pread, GLIBC_2_1); > + > +strong_alias (__libc_pread64, __default_pread) > +versioned_symbol (libc, __default_pread, pread, GLIBC_2_2); > + > +/* It is a libc_hidden_def (__pread), but with a redirection due the symbol > + versioning. */ > +__hidden_ver1 (__compat_pread, __GI___pread, __compat_pread); > +#endif I believe this is libc_hidden_ver. It took me a while to find it (see the original dance around ___libc_once). This applies else where in this patch and also the pwrite patch. Thanks, Florian