From: Florian Weimer <fweimer@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] elf: ld.so --help calls _dl_init_paths without a main map [BZ #27577]
Date: Mon, 15 Mar 2021 13:55:11 +0100 [thread overview]
Message-ID: <87o8fkvaog.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <CAMe9rOrok-9WL8X_wGtx791wWL60EmOyy13m_HhoNsnDb+=VnQ@mail.gmail.com> (H. J. Lu's message of "Mon, 15 Mar 2021 05:48:56 -0700")
* H. J. Lu:
> On Mon, Mar 15, 2021 at 5:28 AM Florian Weimer <fweimer@redhat.com> wrote:
>>
>> * H. J. Lu:
>>
>> > On Mon, Mar 15, 2021 at 5:14 AM Florian Weimer <fweimer@redhat.com> wrote:
>> >>
>> >> * H. J. Lu:
>> >>
>> >> >> +$(objpfx)tst-rtld-help.out: $(objpfx)ld.so
>> >> >> + $(test-wrapper) $(rtld-prefix) --help > $@; \
>> >> >> + $(evaluate-test)
>> >> >> +$(objpfx)tst-rtld-help-2.out: $(objpfx)tst-rtld-help.out
>> >> >> + grep -q 'Legacy HWCAP subdirectories under library search path directories' $<; \
>> >> >> + $(evaluate-test)
>> >> >
>> >> > Can we avoid tst-rtld-help-2.out by grep $@ directly?
>> >>
>> >> We could use &&, but that would make diagnosing test failures difficult
>> >> (as in: did --help fail, or grep?). The separate test seemed the
>> >> easiest way.
>> >
>> > Running "ld.so --help" itself is very straight forward. When there is
>> > foo.out, I usually search for foo.
>>
>> Sorry, I don't understand what your comment means in this context.
>> Would you please elaborate?
>
> A single tst-rtld-help.out doesn't make diagnosing ld.so --help
> failures difficult.
> Multiple output files is confusing.
All mtrace tests do this. However, I will submit a different patch with
just one target.
Thanks,
Florian
next prev parent reply other threads:[~2021-03-15 12:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 10:03 Florian Weimer
2021-03-15 12:10 ` H.J. Lu
2021-03-15 12:14 ` Florian Weimer
2021-03-15 12:24 ` H.J. Lu
2021-03-15 12:28 ` Florian Weimer
2021-03-15 12:48 ` H.J. Lu
2021-03-15 12:55 ` Florian Weimer [this message]
2021-03-15 12:49 ` Andreas Schwab
2021-03-15 12:55 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8fkvaog.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).