From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id 7BCA3383E825 for ; Mon, 29 Jun 2020 09:42:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7BCA3383E825 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-189-QWX8l7hlN7GoWdvxDLbtHw-1; Mon, 29 Jun 2020 05:11:50 -0400 X-MC-Unique: QWX8l7hlN7GoWdvxDLbtHw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 33251A0C01; Mon, 29 Jun 2020 09:11:49 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-112-196.ams2.redhat.com [10.36.112.196]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0BADF5D9D3; Mon, 29 Jun 2020 09:11:47 +0000 (UTC) From: Florian Weimer To: Alistair Francis via Libc-alpha Cc: Andreas Schwab , Alistair Francis , Alistair Francis Subject: Re: [PATCH] Allow memset local PLT reference for RISC-V. References: <20200622211034.659739-1-alistair.francis@wdc.com> <87zh8u8d17.fsf@igel.home> Date: Mon, 29 Jun 2020 11:11:46 +0200 In-Reply-To: (Alistair Francis via Libc-alpha's message of "Wed, 24 Jun 2020 15:25:06 -0700") Message-ID: <87o8p21bjh.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jun 2020 09:42:08 -0000 * Alistair Francis via Libc-alpha: > On Tue, Jun 23, 2020 at 12:19 AM Andreas Schwab wrote: >> >> On Jun 22 2020, Alistair Francis via Libc-alpha wrote: >> >> > This is similar to commit a26e2e9feab87d4f745c31411458b048742ac733 >> > "Allow memset local PLT reference for powerpc soft-float.". >> > >> > GCC 10.1 results in the localplt test failing for RISC-V. >> >> Why doesn't the redirect in sysdeps/generic/symbol-hacks.h work? > > I'm not sure. > > I suspect it's the same reason it didn't work in the commit this is > based off: a26e2e9feab87d4f745c31411458b048742ac733 > "Allow memset local PLT reference for powerpc soft-float.". > > The error is part of glibc's check scripts. I'm assuming memset is in > the binary which produces a check failure as we don't expect it to be. > I'm not sure where sysdeps/generic/symbol-hacks.h is involved in this > process though. Please post disassembly showing the location of the PLT calls. Which functions have them? Thanks, Florian