From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from albireo.enyo.de (albireo.enyo.de [37.24.231.21]) by sourceware.org (Postfix) with ESMTPS id C34B6384B0C1 for ; Tue, 21 Apr 2020 11:56:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C34B6384B0C1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=deneb.enyo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=fw@deneb.enyo.de Received: from [172.17.203.2] (helo=deneb.enyo.de) by albireo.enyo.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) id 1jQrVw-00046F-GM; Tue, 21 Apr 2020 11:56:32 +0000 Received: from fw by deneb.enyo.de with local (Exim 4.92) (envelope-from ) id 1jQrVw-0001mN-Dd; Tue, 21 Apr 2020 13:56:32 +0200 From: Florian Weimer To: Adhemerval Zanella via Libc-alpha Subject: Re: [PATCH 2/4] ia64: Remove sigprocmask/sigblock objects from libpthread References: <20200313194827.4467-1-adhemerval.zanella@linaro.org> <20200313194827.4467-2-adhemerval.zanella@linaro.org> Date: Tue, 21 Apr 2020 13:56:32 +0200 In-Reply-To: <20200313194827.4467-2-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Fri, 13 Mar 2020 16:48:25 -0300") Message-ID: <87o8rlrr0v.fsf@mid.deneb.enyo.de> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Apr 2020 11:56:35 -0000 * Adhemerval Zanella via Libc-alpha: > It is required because __libc_unwind_longjmp (used on thread > cancellation) calls __sigprocmask. Replace with a direct call. > > The sigblock was never exported and thus unused. Perhaps: They are required because __libc_unwind_longjmp (used for thread cancellation) calls __sigprocmask. Replace this with a direct call. The sigblock function is not exported and is not used internally, so it can be removed. > Checked on cross build for ia64-linux-gnu. I can put this through a build-many-glibcs.py run just to be sure (once the first patch is ready as well), but change itself looks good to me.