Re: [PATCH v2 1/4] nptl: Move pthread_sigmask implementation to libc

[Florian Weimer <fw@deneb.enyo.de>]

* Adhemerval Zanella via Libc-alpha:

> diff --git a/nptl/libpthread-compat.c b/nptl/libpthread-compat.c
> index 512b4c77c8..92c981c2d2 100644
> --- a/nptl/libpthread-compat.c
> +++ b/nptl/libpthread-compat.c
> @@ -36,6 +36,12 @@ __libpthread_version_placeholder (void)
>     version or later, the placeholder symbol is not needed because
>     there are plenty of other symbols which populate those later
>     versions.  */
> +
> +#if (SHLIB_COMPAT (libpthread, GLIBC_2_0, GLIBC_2_1))
> +compat_symbol_unique (libpthread,
> +		      __libpthread_version_placeholder, GLIBC_2_0);
> +#endif
> +

I do not think this is necessary yet because there are other symbols
which keep the version alive.

> diff --git a/nptl/pthreadP.h b/nptl/pthreadP.h
> index 06fb0d74c5..edec8d0501 100644
> --- a/nptl/pthreadP.h
> +++ b/nptl/pthreadP.h
> @@ -482,6 +482,8 @@ extern void __pthread_testcancel (void);
>  extern int __pthread_clockjoin_ex (pthread_t, void **, clockid_t,
>  				   const struct timespec *, bool)
>    attribute_hidden;
> +extern int __pthread_sigmask (int how, const sigset_t *newmask,
> +			      sigset_t *oldmask);

I suggest to drop it.  It's not exported, and local users cannot call
it because it's not hidden (the usual check-localplt failure).

sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/libc.abilist seems to
be missing from the abilist updates.  Rest of the abilist changes look
okay to me.