public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Carlos O'Donell <carlos@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] manual: Document lack of conformance of sched_* functions [BZ #14829]
Date: Fri, 14 Dec 2018 21:09:00 -0000	[thread overview]
Message-ID: <87o99ng6kg.fsf@oldenburg2.str.redhat.com> (raw)
In-Reply-To: <74c5309f-ca7a-ae8b-5704-86329525cfde@redhat.com> (Carlos O'Donell's message of "Fri, 14 Dec 2018 15:55:14 -0500")

* Carlos O'Donell:

>> 2018-12-07  Florian Weimer  <fweimer@redhat.com>
>> 
>> 	[BZ #14829]
>> 	* manual/resource.texi (Basic Scheduling Functions): Add
>> 	portability note.  Change process to task throughout the section.
>> 	Remove incorrect comment about sched_yield as it affects
>> 	tasks/threads, not entire processes.
>
> I think we need a *big* comment in sysdeps/unix/sysv/linux/bits/posix_opt.h
> around the define of _POSIX_PRIORITY_SCHEDULING which says:
>
> /* On Linux we do not conform to the POSIX requirements for setting
>    _POSIX_PRIORITY_SCHEDULING, and it should be set to -1, but it has
>    been enabled for so long that we cannot risk setting it to -1 without
>    serious issues arising with existing applications, so we leave it enabled
>    even though on Linux the APIs all take thread IDs.  Please see bug 14829.  */
>
> What do you think?

I think that is a separate discussion.

We could stop defining _POSIX_PRIORITY_SCHEDULING to -1, but still
provide the corresponding definitions and declarations under
_GNU_SOURCE.  Whether that's feasible requires substantial additional
research.

I'm fine with adding a comment to
sysdeps/unix/sysv/linux/bits/posix_opt.h along the lines you suggested,
maybe:

/* Priority scheduling is not supported with the correct semantics, but
   GNU/Linux applications expect that the corresponding interfaces are
   available, even though the semantics do not meet the POSIX
   requirements.  */
#define	_POSIX_PRIORITY_SCHEDULING	200809L

Or we could use the text you proposed.

>> diff --git a/manual/resource.texi b/manual/resource.texi
>> index 8bc2a803d4..f02192475a 100644
>> --- a/manual/resource.texi
>> +++ b/manual/resource.texi
>> @@ -750,6 +750,14 @@ policy, if anything, only fine tunes the effect of that priority.
>>  
>>  The symbols in this section are declared by including file @file{sched.h}.
>>  
>> +@strong{Portability Note:} In POSIX, the @code{pid_t} arguments of the
>> +functions below refer to process IDs.  On Linux, they are actually
>> +thread IDs, and control how specific threads are scheduled with
>> +regards to the entire system.  The resulting behavior does not conform
>> +to POSIX.  This is why the following description refers to tasks and
>> +tasks IDs, and not processes and process IDs.
>> +@c https://sourceware.org/bugzilla/show_bug.cgi?id=14829
>
> OK.
>
> Should we also mention that PTHREAD_SCOPE_PROCESS is entirely unsupported by
> glibc on Linux?

Wouldn't that be something for the documentation of
pthread_attr_setscope, which does not exist yet?

Thanks,
Florian

  reply	other threads:[~2018-12-14 21:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-07 13:01 Florian Weimer
2018-12-14 20:57 ` Carlos O'Donell
2018-12-14 21:09   ` Florian Weimer [this message]
2018-12-14 21:20     ` Carlos O'Donell
2018-12-14 22:30       ` Florian Weimer
2019-01-09 12:31         ` Florian Weimer
2019-01-09 16:14         ` Carlos O'Donell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o99ng6kg.fsf@oldenburg2.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=carlos@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).