From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 07DE03849AEF for ; Sat, 13 Apr 2024 15:52:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 07DE03849AEF Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 07DE03849AEF Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713023574; cv=none; b=kgFTASqtwrepekd8mK1EEYqB8SD7yd29z9UPz5NjVOOtG9RSyfh0/BPzlpVNn7wTvrIYoRTUB7SZkT8mdh+LAuAvsL8qDLNSdgGPEKnrtuTFZbzE0xz7210nk6wcH6lAJV2qcQs/enO6jXVErw+PqqBpBAh6Ue037/eJj0hfbOc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713023574; c=relaxed/simple; bh=4rBFZqzZ/5gOuTHSGWEQxz1CLJRoxbyDIC0ajK1LRjw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=nZkpk4GpGX/DiehyDb84xj8dlae6utTcQ3P5BrH5dw/bS1+fQVtvuYfVotn1UE73VPEcfGb6x/pB/DM0aRblfhXg6Pn7XJC1fXpMRDu/zSZwOIrHV0thd0avr/I6ll44+XaS7YCwhuM1451jbsgCY76QwiCzkZ7+WhhZK4enxlY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713023572; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zMK44nXmVvXUKUEbpJK1Hdy8aw38+/KlEvfupeI87NI=; b=bFOGRjDjI2B215D5Ztk6v/wj0VRRiEvnnrtV2Ja3xcgMLRuKnYWmZD7HWaZYCUhqKhu22O SPdeiVDblIh+qrr3go+sYydGdjyCegroOzqZXq9FMKfi1onqoDndWLohicySkvIKl3UgqL VqXjMQq4aBO7GVhxrXNrSeAzGsGIDNw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-344-4AElEsAXPsK8ESP2eqYHlg-1; Sat, 13 Apr 2024 11:52:49 -0400 X-MC-Unique: 4AElEsAXPsK8ESP2eqYHlg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 483EE1044572; Sat, 13 Apr 2024 15:52:49 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.193.5]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 678032026D0A; Sat, 13 Apr 2024 15:52:48 +0000 (UTC) From: Florian Weimer To: "H.J. Lu" Cc: libc-alpha@sourceware.org, Sunil K Pandey Subject: Re: [PATCH] Revert "x86_64: Suppress false positive valgrind error" In-Reply-To: (H. J. Lu's message of "Sat, 13 Apr 2024 08:49:48 -0700") References: <87a5lx2u9a.fsf@oldenburg.str.redhat.com> <875xwl2tku.fsf@oldenburg.str.redhat.com> <871q792ssr.fsf@oldenburg.str.redhat.com> Date: Sat, 13 Apr 2024 17:52:42 +0200 Message-ID: <87plut1cqd.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * H. J. Lu: > On Sat, Apr 13, 2024 at 8:27=E2=80=AFAM H.J. Lu wro= te: >> >> On Sat, Apr 13, 2024 at 8:20=E2=80=AFAM Florian Weimer wrote: >> > >> > * H. J. Lu: >> > >> > > On Sat, Apr 13, 2024 at 8:03=E2=80=AFAM Florian Weimer wrote: >> > >> >> > >> * H. J. Lu: >> > >> >> > >> > On Sat, Apr 13, 2024 at 7:49=E2=80=AFAM Florian Weimer wrote: >> > >> >> >> > >> >> This reverts commit a1735e0aa858f0c8b15e5ee9975bff4279423680. >> > >> >> >> > >> >> The test failure is a real valgrind bug that needs to be fixed b= efore >> > >> >> valgrind is usable with a glibc that has been built with >> > >> >> CC=3D"gcc -march=3Dx86-64-v3". The valgrind fix addresses the o= bserved >> > >> >> test failure as well. >> > >> >> >> > >> >> Upstream bug: >> > >> >> >> > >> >> Tested on x86_64-linux-gnu with and without CC=3D"gcc -march=3Dx= 86-64-v3". >> > >> >> The elf/tst-valgrind-smoke tests again fails with an unpatched v= algrind, >> > >> >> and the proposed upstream patch fixes it. (Apparently, valgrind >> > >> >> matches on soname, and not the file name, which is ld.so in the = test.) >> > >> > >> > >> > Please clarify that your patch fixes the glibc valgrind test by n= ot using >> > >> > strcmp-avx2.S in the valgrind test. >> > >> >> > >> Sorry, clarify where? In the commit message here? On the upstream= bug? >> > > >> > > In the glibc commit message. >> > > >> > >> My valgrind patch replaces the strcmp implementation in ld.so with = its >> > >> own. >> > >> >> > > >> > > Please mention it in the glibc commit message. >> > >> > Okay, I'll send a v2. >> > >> > Could someone proficient in x86-64 assembly have a look at my strcmp >> > implementation? >> >> Can you adapt sysdeps/i386/i686/strcmp.S for valgrind? >> > > You can use sysdeps/x86_64/strcmp.S from glibc 2.10: True. It's mostly a licensing matter at this point. The copyright notice is longer than the assemly =E2=80=A6 Florian