public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] io: Fix record locking contants for powerpc64 with __USE_FILE_OFFSET64
Date: Tue, 29 Aug 2023 09:59:02 +0200	[thread overview]
Message-ID: <87pm36nut5.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20230828213721.2957677-1-aurelien@aurel32.net> (Aurelien Jarno's message of "Mon, 28 Aug 2023 23:37:21 +0200")

* Aurelien Jarno:

> diff --git a/sysdeps/unix/sysv/linux/powerpc/bits/fcntl.h b/sysdeps/unix/sysv/linux/powerpc/bits/fcntl.h
> index f7615a447e..d8a291a331 100644
> --- a/sysdeps/unix/sysv/linux/powerpc/bits/fcntl.h
> +++ b/sysdeps/unix/sysv/linux/powerpc/bits/fcntl.h
> @@ -33,7 +33,7 @@
>  # define __O_LARGEFILE	0200000
>  #endif
>  
> -#if __WORDSIZE == 64
> +#if __WORDSIZE == 64 && !defined __USE_FILE_OFFSET64
>  # define F_GETLK	5
>  # define F_SETLK	6
>  # define F_SETLKW	7

I find this puzzling.  Why would __USE_FILE_OFFSET64 have an effect if
__WORDSIZE is 64?

Thanks,
Florian


  reply	other threads:[~2023-08-29  7:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-28 21:37 Aurelien Jarno
2023-08-29  7:59 ` Florian Weimer [this message]
2023-08-29 13:20   ` Adhemerval Zanella Netto
2023-08-29 16:30     ` Aurelien Jarno
2023-08-29 17:06       ` Adhemerval Zanella Netto
2023-08-30  9:19       ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pm36nut5.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=aurelien@aurel32.net \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).