Re: [PATCH v5 10/11] libio: Convert __obstack_vprintf_internal to buffers (bug 27124)

[Florian Weimer <fweimer@redhat.com>]

* Adhemerval Zanella Netto:

> On 12/12/22 12:24, Florian Weimer via Libc-alpha wrote:
>> This fixes bug 27124 because the problematic built-in vtable is gone.
>
> Patch looks good, some minor nit below.
>
>> ---
>>  include/printf_buffer.h            |   4 +
>>  libio/obprintf.c                   | 170 +++++++++--------------------
>>  stdio-common/printf_buffer_flush.c |   4 +
>>  3 files changed, 58 insertions(+), 120 deletions(-)
>> 
>> diff --git a/include/printf_buffer.h b/include/printf_buffer.h
>> index 3d4ef1d06c..a8211dd657 100644
>> --- a/include/printf_buffer.h
>> +++ b/include/printf_buffer.h
>> @@ -54,6 +54,7 @@ enum __printf_buffer_mode
>>      __printf_buffer_mode_fp,         /* For __printf_fp_l_buffer.  */
>>      __printf_buffer_mode_fp_to_wide, /* For __wprintf_fp_l_buffer.  */
>>      __printf_buffer_mode_fphex_to_wide, /* For __wprintf_fphex_l_buffer.  */
>> +    __printf_buffer_mode_obstack,
>
> Maybe add 'For __printf_buffer_flush_obstack'?

Fixed.

>> -/* the jump table.  */
>> -const struct _IO_jump_t _IO_obstack_jumps libio_vtable attribute_hidden =
>> -{

> Remove _IO_obstack_jumps from tst-relro-libc.out list.

Right, fixed.

Thanks,
Florian