From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id A3EA9386E55C for ; Fri, 16 Dec 2022 18:25:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A3EA9386E55C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671215154; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/RFWI8YCCHtlZ2eqB1rc3cR7zFYfME4qUz9RFKkm9IQ=; b=gaIAeA2U+0jr1XnWGsFk6y5GjEHmMxZN87JT/p3b3UMgIhZLd2l9MrJ2CUo6vOwlcIlzgD /r5wRJYPlBTtYvSAvF6ERu4NvfF70fkRrezAe3JoRPfL5PCnCK9SBO2SYVy6ODFgHC6lsy Yorq/meSnqjXcEdKXQs8ssIezda4SBM= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-201-As73YOWPNYunn28UW_JfpA-1; Fri, 16 Dec 2022 13:25:50 -0500 X-MC-Unique: As73YOWPNYunn28UW_JfpA-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7BA43281DE72; Fri, 16 Dec 2022 18:25:50 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.61]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D5C93492C14; Fri, 16 Dec 2022 18:25:49 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Netto Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v5 10/11] libio: Convert __obstack_vprintf_internal to buffers (bug 27124) References: <45234c5d6ba9556451424940fa746e9e66b1a6f4.1670858473.git.fweimer@redhat.com> <9ab5f463-fe9c-8c11-7b83-d9e330bc0275@linaro.org> Date: Fri, 16 Dec 2022 19:25:47 +0100 In-Reply-To: <9ab5f463-fe9c-8c11-7b83-d9e330bc0275@linaro.org> (Adhemerval Zanella Netto's message of "Thu, 15 Dec 2022 16:14:43 -0300") Message-ID: <87pmcjrys4.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Adhemerval Zanella Netto: > On 12/12/22 12:24, Florian Weimer via Libc-alpha wrote: >> This fixes bug 27124 because the problematic built-in vtable is gone. > > Patch looks good, some minor nit below. > >> --- >> include/printf_buffer.h | 4 + >> libio/obprintf.c | 170 +++++++++-------------------- >> stdio-common/printf_buffer_flush.c | 4 + >> 3 files changed, 58 insertions(+), 120 deletions(-) >> >> diff --git a/include/printf_buffer.h b/include/printf_buffer.h >> index 3d4ef1d06c..a8211dd657 100644 >> --- a/include/printf_buffer.h >> +++ b/include/printf_buffer.h >> @@ -54,6 +54,7 @@ enum __printf_buffer_mode >> __printf_buffer_mode_fp, /* For __printf_fp_l_buffer. */ >> __printf_buffer_mode_fp_to_wide, /* For __wprintf_fp_l_buffer. */ >> __printf_buffer_mode_fphex_to_wide, /* For __wprintf_fphex_l_buffer. */ >> + __printf_buffer_mode_obstack, > > Maybe add 'For __printf_buffer_flush_obstack'? Fixed. >> -/* the jump table. */ >> -const struct _IO_jump_t _IO_obstack_jumps libio_vtable attribute_hidden = >> -{ > Remove _IO_obstack_jumps from tst-relro-libc.out list. Right, fixed. Thanks, Florian