From: Florian Weimer <fweimer@redhat.com>
To: Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
"Andreas K . Huettel" <dilfridge@gentoo.org>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>
Subject: Re: [PATCH v2] m68k: Enforce 4-byte alignment on internal locks (BZ #29537)
Date: Tue, 20 Sep 2022 14:49:09 +0200 [thread overview]
Message-ID: <87pmfqmcsa.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20220905171043.1097209-1-adhemerval.zanella@linaro.org> (Adhemerval Zanella via Libc-alpha's message of "Mon, 5 Sep 2022 14:10:43 -0300")
* Adhemerval Zanella via Libc-alpha:
> A new internal definition, __LIBC_LOCK_ALIGNMENT, is used to force
> the 4-byte alignment only for m68k, other architecture keep the
> natural alignment of the type used internally (and hppa does not
> require 16-byte alignment for kernel-assisted CAS).
> ---
> sysdeps/generic/libc-lock-arch.h | 25 +++++++++++++++++++
> sysdeps/nptl/libc-lock.h | 8 +++++-
> sysdeps/nptl/libc-lockP.h | 3 ++-
> sysdeps/unix/sysv/linux/m68k/libc-lock-arch.h | 25 +++++++++++++++++++
> 4 files changed, 59 insertions(+), 2 deletions(-)
> create mode 100644 sysdeps/generic/libc-lock-arch.h
> create mode 100644 sysdeps/unix/sysv/linux/m68k/libc-lock-arch.h
This is okay.
Reviewed-by: Florian Weimer <fweimer@redhat.com>
Thanks,
Florian
prev parent reply other threads:[~2022-09-20 12:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 17:10 Adhemerval Zanella
2022-09-14 18:56 ` Andreas K. Huettel
2022-09-20 12:49 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmfqmcsa.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=dilfridge@gentoo.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).