From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E7ADA3857C40 for ; Wed, 10 Aug 2022 07:46:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E7ADA3857C40 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-614-g6bExvQyO56nAMepPm5VmA-1; Wed, 10 Aug 2022 03:46:23 -0400 X-MC-Unique: g6bExvQyO56nAMepPm5VmA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 15A85805B72; Wed, 10 Aug 2022 07:46:23 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.75]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 594112026D4C; Wed, 10 Aug 2022 07:46:22 +0000 (UTC) From: Florian Weimer To: Fangrui Song via Libc-alpha Subject: Re: [PATCH] elf.h: Add ELFCOMPRESS_ZSTD References: <20220708233233.2554110-1-maskray@google.com> Date: Wed, 10 Aug 2022 09:46:20 +0200 In-Reply-To: <20220708233233.2554110-1-maskray@google.com> (Fangrui Song via Libc-alpha's message of "Fri, 8 Jul 2022 16:32:33 -0700") Message-ID: <87pmh8fsmr.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Aug 2022 07:46:28 -0000 * Fangrui Song via Libc-alpha: > Link: https://sourceware.org/pipermail/gnu-gabi/2022q2/000498.html ("New ch_type value ELFCOMPRESS_ZSTD?") > Link: https://groups.google.com/g/generic-abi/c/satyPkuMisk ("Add new ch_type value: ELFCOMPRESS_ZSTD") > > --- > > I wish that the macro definition can catch up the upcoming > https://sourceware.org/glibc/wiki/Release/2.36 [1], so that > projects can expect the value ELFCOMPRESS_ZSTD from elf.h. > The projects may choose to define the macro themselves, > but having the definition in an earlier release seems a good idea > anyway, and it the glibc definition makes it clearer ELFCOMPRESS_ZSTD > is standard and vendors can start adding support. > > [1]: https://sourceware.org/pipermail/libc-alpha/2022-July/140352.html > ("Release of glibc 2.36 in 1 month! Please add blockers and desirable for release.") > > From https://groups.google.com/g/generic-abi/c/9OO5vhxb00Y ("Ongoing Maintenance of the gABI"), > we should be able to define this once Cary agrees. > --- > elf/elf.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/elf/elf.h b/elf/elf.h > index 2b5c2c5fb6..f6ae2348a9 100644 > --- a/elf/elf.h > +++ b/elf/elf.h > @@ -505,6 +505,7 @@ typedef struct > > /* Legal values for ch_type (compression algorithm). */ > #define ELFCOMPRESS_ZLIB 1 /* ZLIB/DEFLATE algorithm. */ > +#define ELFCOMPRESS_ZSTD 2 /* Zstandard algorithm. */ > #define ELFCOMPRESS_LOOS 0x60000000 /* Start of OS-specific. */ > #define ELFCOMPRESS_HIOS 0x6fffffff /* End of OS-specific. */ > #define ELFCOMPRESS_LOPROC 0x70000000 /* Start of processor-specific. */ Could you repost this with the actual commit message you intend to use? Thanks, Florian