* [PATCH] elf: Fix direction of NODELETE log messages during symbol lookup
@ 2022-07-05 7:00 Florian Weimer
2022-07-05 12:39 ` Adhemerval Zanella
0 siblings, 1 reply; 2+ messages in thread
From: Florian Weimer @ 2022-07-05 7:00 UTC (permalink / raw)
To: libc-alpha
NODELETE status is propagated from the referencing object to the
referenced object, not the other way round. The code is correct, only
the log message has the wrong direction.
Tested on i686-linux-gnu and x86_64-linux-gnu.
---
elf/dl-lookup.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/elf/dl-lookup.c b/elf/dl-lookup.c
index 8cb32321da..4c86dc694e 100644
--- a/elf/dl-lookup.c
+++ b/elf/dl-lookup.c
@@ -646,11 +646,11 @@ add_dependency (struct link_map *undef_map, struct link_map *map, int flags)
{
if (undef_map->l_name[0] == '\0')
_dl_debug_printf ("\
-marking %s [%lu] as NODELETE due to reference to main program\n",
+marking %s [%lu] as NODELETE due to reference from main program\n",
map->l_name, map->l_ns);
else
_dl_debug_printf ("\
-marking %s [%lu] as NODELETE due to reference to %s [%lu]\n",
+marking %s [%lu] as NODELETE due to reference from %s [%lu]\n",
map->l_name, map->l_ns,
undef_map->l_name, undef_map->l_ns);
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] elf: Fix direction of NODELETE log messages during symbol lookup
2022-07-05 7:00 [PATCH] elf: Fix direction of NODELETE log messages during symbol lookup Florian Weimer
@ 2022-07-05 12:39 ` Adhemerval Zanella
0 siblings, 0 replies; 2+ messages in thread
From: Adhemerval Zanella @ 2022-07-05 12:39 UTC (permalink / raw)
To: Florian Weimer; +Cc: libc-alpha
> On 5 Jul 2022, at 04:00, Florian Weimer via Libc-alpha <libc-alpha@sourceware.org> wrote:
>
> NODELETE status is propagated from the referencing object to the
> referenced object, not the other way round. The code is correct, only
> the log message has the wrong direction.
>
> Tested on i686-linux-gnu and x86_64-linux-gnu.
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>
> ---
> elf/dl-lookup.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/elf/dl-lookup.c b/elf/dl-lookup.c
> index 8cb32321da..4c86dc694e 100644
> --- a/elf/dl-lookup.c
> +++ b/elf/dl-lookup.c
> @@ -646,11 +646,11 @@ add_dependency (struct link_map *undef_map, struct link_map *map, int flags)
> {
> if (undef_map->l_name[0] == '\0')
> _dl_debug_printf ("\
> -marking %s [%lu] as NODELETE due to reference to main program\n",
> +marking %s [%lu] as NODELETE due to reference from main program\n",
> map->l_name, map->l_ns);
> else
> _dl_debug_printf ("\
> -marking %s [%lu] as NODELETE due to reference to %s [%lu]\n",
> +marking %s [%lu] as NODELETE due to reference from %s [%lu]\n",
> map->l_name, map->l_ns,
> undef_map->l_name, undef_map->l_ns);
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-05 12:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-05 7:00 [PATCH] elf: Fix direction of NODELETE log messages during symbol lookup Florian Weimer
2022-07-05 12:39 ` Adhemerval Zanella
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).