From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 9D429385840D for ; Mon, 30 Aug 2021 09:26:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9D429385840D Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-237-bG_cewXTNJSI-HYreIaK2A-1; Mon, 30 Aug 2021 05:26:52 -0400 X-MC-Unique: bG_cewXTNJSI-HYreIaK2A-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C01E3802937; Mon, 30 Aug 2021 09:26:51 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.194.140]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E54221002391; Mon, 30 Aug 2021 09:26:50 +0000 (UTC) From: Florian Weimer To: Adhemerval Zanella Cc: libc-alpha@sourceware.org Subject: Re: [PATCH v2 17/19] nptl: Use tidlock when accessing TID on pthread_sigqueue References: <20210823195047.543237-1-adhemerval.zanella@linaro.org> <20210823195047.543237-18-adhemerval.zanella@linaro.org> <87eeag5ksb.fsf@oldenburg.str.redhat.com> Date: Mon, 30 Aug 2021 11:26:48 +0200 In-Reply-To: (Adhemerval Zanella's message of "Thu, 26 Aug 2021 14:49:32 -0300") Message-ID: <87pmtvs2p3.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Aug 2021 09:26:57 -0000 * Adhemerval Zanella: >>> + else >>> + res = -ESRCH; >> >> We can return 0 in this case, I think. > > No sure about this, we can return 0 but it means signal won't be potentially > delivered. The thread may have already started exiting and blocked the signals when pthread_sigqueue is called. In that case, it would return 0 even though the signal is never delivered. Thanks, Florian