From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tglx@linutronix.de>
Received: from galois.linutronix.de (Galois.linutronix.de
 [IPv6:2a0a:51c0:0:12e:550::1])
 by sourceware.org (Postfix) with ESMTPS id 0DEF63857C75
 for <libc-alpha@sourceware.org>; Wed, 12 May 2021 20:55:07 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0DEF63857C75
From: Thomas Gleixner <tglx@linutronix.de>
To: "Bae\, Chang Seok" <chang.seok.bae@intel.com>,
 Borislav Petkov <bp@alien8.de>
Cc: Andy Lutomirski <luto@kernel.org>, "bp\@suse.de" <bp@suse.de>,
 "mingo\@kernel.org" <mingo@kernel.org>, "x86\@kernel.org" <x86@kernel.org>,
 "Brown\, Len" <len.brown@intel.com>, "Hansen\, Dave" <dave.hansen@intel.com>,
 "hjl.tools\@gmail.com" <hjl.tools@gmail.com>,
 "Dave.Martin\@arm.com" <Dave.Martin@arm.com>,
 "jannh\@google.com" <jannh@google.com>,
 "mpe\@ellerman.id.au" <mpe@ellerman.id.au>,
 "carlos\@redhat.com" <carlos@redhat.com>, "Luck\, Tony" <tony.luck@intel.com>,
 "Shankar\, Ravi V" <ravi.v.shankar@intel.com>,
 "libc-alpha\@sourceware.org" <libc-alpha@sourceware.org>,
 "linux-arch\@vger.kernel.org" <linux-arch@vger.kernel.org>,
 "linux-api\@vger.kernel.org" <linux-api@vger.kernel.org>,
 "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 5/6] x86/signal: Detect and prevent an alternate signal
 stack overflow
In-Reply-To: <B8EF2379-0AF6-4D00-B6B8-214CA9073BFC@intel.com>
References: <20210422044856.27250-1-chang.seok.bae@intel.com>
 <20210422044856.27250-6-chang.seok.bae@intel.com> <YJrOsbyYhMndI5jd@zn.tnic>
 <B8EF2379-0AF6-4D00-B6B8-214CA9073BFC@intel.com>
Date: Wed, 12 May 2021 22:55:04 +0200
Message-ID: <87pmxv65av.ffs@nanos.tec.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: libc-alpha@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>,
 <mailto:libc-alpha-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 12 May 2021 20:55:08 -0000

On Wed, May 12 2021 at 18:48, Chang Seok Bae wrote:
> On May 11, 2021, at 11:36, Borislav Petkov <bp@alien8.de> wrote:
>> 
>> I clumsily tried to register a SIGSEGV handler with
>> 
>>        act.sa_sigaction = my_sigsegv;
>>        sigaction(SIGSEGV, &act, NULL);
>> 
>> but that doesn't fire - task gets killed. Maybe I'm doing it wrong.
>
> Since the altstack is already overflowed, perhaps set the flag like this -- not
> using it to get the handler:
>
> 	act.sa_sigaction = my_sigsegv;
> +	act.sa_flags = SA_SIGINFO;
> 	sigaction(SIGSEGV, &act, NULL);
>
> FWIW, I think this is just a workaround for this case; in practice, altstack is
> rather a backup for normal stack corruption.

That's the intended usage, but it's not limited to that and there exists
creative (ab)use of sigaltstack beyond catching the overflow of the
regular stack.

Thanks,

        tglx